Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/shiny/driver/mtldriver: fails to build on darwin/arm64 because its mtl dependency doesn't support darwin/arm64 yet #43221

Closed
bcmills opened this issue Dec 16, 2020 · 5 comments
Closed

x/exp/shiny/driver/mtldriver: fails to build on darwin/arm64 because its mtl dependency doesn't support darwin/arm64 yet #43221

bcmills opened this issue Dec 16, 2020 · 5 comments
Labels
arch-arm64 FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 16, 2020

2020-12-15T15:35:30-b5a6e24/darwin-arm64-11_0-toothrot

# dmitri.shuralyov.com/gpu/mtl
In file included from mtl.m:5:
/tmp/buildlet/gopath/pkg/mod/dmitri.shuralyov.com/gpu/[email protected]/mtl.h:3:21: error: typedef redefinition with different types ('signed char' vs 'bool')
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/objc/objc.h:78:18: note: previous definition is here

CC @golang/release @dmitshur
@bcmills bcmills added OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. arch-arm64 labels Dec 16, 2020
@gopherbot gopherbot added this to the Unreleased milestone Dec 16, 2020
@mvdan
Copy link
Member

mvdan commented Dec 16, 2020

Does such a complex dependency really belong in x/exp? It feels like it will mean a continuous investment of time to keep it working on all the platforms we have builders on, which is probably the kind of work that belongs outside the x repos.

@dmitshur dmitshur self-assigned this Dec 16, 2020
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Dec 16, 2020
@dmitshur
Copy link
Contributor

I've already prototyped a fix locally and intend to clean it up and push it.

@bcmills
Copy link
Contributor Author

bcmills commented Dec 16, 2020 •
edited
Loading

@mvdan, that's an interesting point, because last I checked that package was not actually built as a dependency of x/exp (see #37175 (comment)). I wonder what has changed since that analysis.

@dmitshur
Copy link
Contributor

dmitshur commented Dec 17, 2020 •
edited
Loading

@bcmills In that comment, you ran go list -f [...] all presumably on Linux or another non-Darwin OS, which did not match the Darwin-only golang.org/x/exp/shiny/driver/mtldriver and golang.org/x/exp/shiny/driver/mtldriver/internal/coreanim packages that import mtl.

The mtl package is a real dependency of shiny when it is built with -tags metal on macOS.

@dmitshur dmitshur changed the title x/exp: build failure on darwin-arm64-11_0-toothrot due to C type mismatch in dmitri.shuralyov.com/gpu/mtl x/exp/shiny/driver/mtldriver: fails to build because mtl package it depends on doesn't support darwin/arm64 yet Dec 17, 2020
@dmitshur dmitshur changed the title x/exp/shiny/driver/mtldriver: fails to build because mtl package it depends on doesn't support darwin/arm64 yet x/exp/shiny/driver/mtldriver: fails to build on darwin/arm64 because its mtl dependency doesn't support darwin/arm64 yet Dec 17, 2020
@dmitshur dmitshur mentioned this issue Dec 17, 2020
Closed
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/279293 mentions this issue: shiny/driver/mtldriver: add darwin/arm64 (macOS) support

@golang golang locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-arm64 FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Darwin
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @mvdan @bcmills @gopherbot