-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sum.golang.org: responding with a 410 fifteen minutes after publishing a new module version #42809
Comments
As an extra data point, https://pkg.go.dev/github.com/multiformats/go-multicodec@master renders properly and I can see a new enough version of master. The license is getting recognised, too. cc @heschik @katiehockman |
This comment has been minimized.
This comment has been minimized.
Someone at work points out that this is because I did a Regardless of whether this is expected behavior, it seems fairly counter-intuitive and frustrating to the end user. Perhaps the proxy and sumdb should be taught to invalidate such a cached state when a new version is published. |
To clarify, the timeline was:
So it almost seems like I should |
See also #41986 410 seems a strong response to give for a tag that has never been seen by the sum server since clients are free to interpret that as a permanent status. 404 would more appropriate for unknown tags, leaving 410 for retracted ones. |
For the caching, this is working as intended. Though I do find it a bit odd that the request worked for proxy.golang.org but not for sum.golang.org. #34370 (comment) provides a bit of context about why we haven't lowered the negative cache time.
There is no way for the proxy or sumdb to know that a new version has been published without attempting to fetch it. Currently, the entire system works on a pull model, and there is no "push" model available for us to be informed of a new version. from @iand :
This is purely an implementation detail of proxy.golang.org and sum.golang.org, in order to work with out internal caching. 410 can be treated as a 404 in this context. |
I'm going to close this as there is no further action to take at this time. |
Thanks for your quick response.
I think closing this issue on the technicality that the cache isn't buggy is a mistake. The cache is an implementation detail that I shouldn't need to worry about, in general. The steps I shared above are pretty common, I think - that is, doing the first
So, it's clearly been longer than a minute, hence I file the bug. At the very least, if the confusing UX is here to stay, I certainly believe it should be clearly documented. Because, right now, the "after one minute" goes directly against my experience of seeing nothing for over half an hour. |
I've run into this problem so many times, so first of all, I'd like to thank @mvdan for raising this issue. It's been really annoying to have to wait for half an hour just to bubble up a version update, so my - not very sophisticated - workaround has been to wait for at least 5 minutes before go getting a new version I just released. Keeping a stale cache entry for half an hour seems like a bad solution in general. Reducing that time to one minute wouldn't be a bad resolution of this issue. Even better would be reducing it to a few seconds with exponential backoff afterwards, but I'm not sure how much overhead that be in the cache implementation. |
That's fair, thanks for making this point about the docs. At a minimum, it may make sense for the documentation to be updated to more clearly state expectations. I'll re-open this so that we can determine the right course of action on this. |
I just ran into this exact problem, and came here as instructed:
A quick solution could be to change that FAQ answer to include the extra detail.
I'd still be a bit annoyed at myself for trying to fetch before pushing the tag, but at least it would save me a few minutes of retrying to see if it had been more than one minute yet. |
Apologies for the delay in updating the documentation. I will do that now and it should be fixed soon. Thanks for everyone's patience. |
Thanks! @katiehockman |
Thanks everyone for your patience! The documentation at proxy.golang.org has been updated. Hopefully this can set more clear expectations, but let me know if it doesn't. |
Yep, it looks clear now, thanks! Personally I'd hope to see that 30-minute worst case scenario be a shorter delay, but I get that it's not an easy tradeoff :) |
One solution that could be easy to implement would be to allow users to ask to refresh the cache for a module when it's marked as unavailable. It's probably not perfect since it requires user interaction, but it seems to be a better solution than having to wait 30 minutes. Allowing user to invalidate the cache could fix some other issues, like when you push a tag and in the minute after you realize you didn't put the tag on the right commit (that can happens if you don't use a CI, and in early stage of a project, it can happens quite easily to not have automated the release process yet). Then the only solution is to create a new tag, and write somewhere "don't use this version, we didn't want to release it but now that it's done it's too late". Even if you delete the tag the version still exists and it can be quite annoying. |
I ran into this exact problem too:
It took me some trial and error to figure out what was going on. Sharing my usage report in case it's helpful. It's starts with the error. The error unfortunately doesn't guide you towards the answer:
Googling around is difficult because the Without much luck, I flailed around a bit:
Finally on a whim, I tried disabling go sum:
That did the trick. It now works as if nothing was ever wrong. |
I ran into this today as well when doing a Edit: I ran into this a second time today. This time while making a new submodule in my project, pushing tags, then updating a dependency and running |
Is there any update on this? It doesn't happen very often, but when it happens, having to wait for the cache entry to expire is such a productivity killer, especially if one is bubbling up changes through a chain of dependencies. |
Still happens. Why the go tooling can't just skip the cache if it returns 404 ? Honestly since introduction of sum.golang.org and proxying the experience of using the tools have been entirely for the worse. Even trying to go around by requesting commit ID instead of tagged version doesn't, and still tries the inept cache:
|
Just bumped into this issue today (I think I can't find another explanation) for project For ~30 minutes I'm not able to build the docker of the distribution (it should accompany the release), because it can't fetch the new version. |
ty sir. this saved me! 🫡 |
At the time of running these commands, I pushed the new version via
git tag -a v0.2.0 && git push --tags
over fifteen minutes ago. Why am I still getting a 410?Note how skipping sum.golang.org alone, or skipping both the sumdb and proxy, make the
go get
work. These commands were run outside of any module.At first I assumed I was holding something wrong, but I've triple-checked everything. You can see the version at https://github.com/multiformats/go-multicodec/blob/v0.2.0/go.mod. I realise that the tag says "five hours ago", because that's when I tagged it - but I only pushed the tag fifteen minutes ago.
The text was updated successfully, but these errors were encountered: