Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/url: add URL.RawFragment, like RawPath #37776

Closed
rsc opened this issue Mar 10, 2020 · 4 comments
Closed

net/url: add URL.RawFragment, like RawPath #37776

rsc opened this issue Mar 10, 2020 · 4 comments

Comments

@rsc
Copy link
Contributor

rsc commented Mar 10, 2020

OpenAPI and JSONSchema do fancy things with the fragment including
funny path operations that distinguish between a literal / and an escaped %2f.
Just like happened with Path, the solution is probably to add RawFragment,
with the same semantics for Fragment/RawFragment as Path/RawPath.

/cc @mpvl

@rsc rsc added this to the Proposal milestone Mar 10, 2020
@rsc rsc changed the title net/url: add URL.RawFragment, like RawPath proposal: net/url: add URL.RawFragment, like RawPath Mar 10, 2020
@rsc
Copy link
Contributor Author

rsc commented Mar 25, 2020

Adding to the proposal minutes. This seems fairly unobjectionable given the precedent set by RawPath. If anyone thinks we shouldn't do this, please speak up. Thanks.

@rsc
Copy link
Contributor Author

rsc commented Apr 1, 2020

Based on the precedent from RawPath and the lack of any objections, this seems like a likely accept.

@rsc
Copy link
Contributor Author

rsc commented Apr 8, 2020

No change in consensus (still crickets here), so accepting.

@rsc rsc modified the milestones: Proposal, Backlog Apr 8, 2020
@rsc rsc changed the title proposal: net/url: add URL.RawFragment, like RawPath net/url: add URL.RawFragment, like RawPath Apr 8, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/227645 mentions this issue: net/url: add URL.RawFragment, URL.EscapedFragment

@golang golang locked and limited conversation to collaborators Apr 16, 2021
@rsc rsc moved this to Accepted in Proposals Aug 10, 2022
@rsc rsc added this to Proposals Aug 10, 2022
@rsc rsc removed this from Proposals Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants