Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestCgoOption fails on Windows because net.cgoLookupHost doesn't exist #35839

Closed
dmitshur opened this issue Nov 26, 2019 · 2 comments
Closed

x/tools/go/packages: TestCgoOption fails on Windows because net.cgoLookupHost doesn't exist #35839

dmitshur opened this issue Nov 26, 2019 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Go1.14

Comments

@dmitshur
Copy link
Contributor

From a recent run of the windows-amd64-longtest builder (after increasing its memory in CL 208500):

--- FAIL: TestCgoOption (0.66s)
    stdlib_test.go:117: no object net.cgoLookupHost
FAIL
FAIL	golang.org/x/tools/go/packages	114.749s

The test tries to look for function cgoLookupHost, which exists in net/cgo_unix.go, but not in net/cgo_windows.go. I don't think the test can pass as is on Windows.

/cc @matloob per owners.
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Windows NeedsFix The path to resolution is known, but the work has not been done. labels Nov 26, 2019
@dmitshur dmitshur added this to the Unreleased milestone Nov 26, 2019
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Nov 26, 2019
@dmitshur dmitshur mentioned this issue Nov 26, 2019
Closed
@dmitshur
Copy link
Contributor Author

I understand this issue is a release blocker for Go 1.14 via #11811 and #35186.

@dmitshur dmitshur modified the milestones: Unreleased, Go1.14 Dec 20, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/212478 mentions this issue: go/packages: fix TestCgoOption to work on Windows

@golang golang locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot