Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/{modfetch,modload}: long tests fail when GOPROXY is set without GOSUMDB #31964

Closed
bcmills opened this issue May 10, 2019 · 6 comments
Closed

cmd/go/internal/{modfetch,modload}: long tests fail when GOPROXY is set without GOSUMDB #31964

bcmills opened this issue May 10, 2019 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13

Comments

@bcmills
Copy link
Contributor

bcmills commented May 10, 2019 

~/go/src$ go version
go version devel +c8068ae1da Fri May 10 11:21:51 2019 -0400 linux/amd64

~/go/src$ GOSUMDB= GOPROXY=https://proxy.golang.org go test cmd/go/internal/{modfetch,modload} -count
=1
go: finding github.com/rsc/vgotest1 v0.0.0
go: finding github.com/rsc/vgotest1/submod v1.0.4
go: finding github.com/rsc/vgotest1 v1.1.0
2019/05/10 11:58:43 verifying github.com/rsc/vgotest1/[email protected]/go.mod: missing GOSUMDB
FAIL    cmd/go/internal/modfetch        1.007s
go: finding golang.org/x/net latest
go: finding golang.org/x/net/context latest
go: downloading golang.org/x/net v0.0.0-20190509222800-a4d6f7feada5
2019/05/10 11:58:45 verifying golang.org/x/[email protected]: missing GOSUMDB
FAIL    cmd/go/internal/modload 2.269s

CC @jayconrod @rsc
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels May 10, 2019
@bcmills bcmills added this to the Go1.13 milestone May 10, 2019
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 10, 2019
@bcmills
Copy link
Contributor Author

bcmills commented May 10, 2019

Somewhat predictably, this bisects to CL 173951.

@bcmills bcmills removed the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label May 10, 2019
@bcmills
Copy link
Contributor Author

bcmills commented May 10, 2019

cmd/go/internal/modfetch also fails with GOSUMDB set to sum.golang.org. That seems even more troubling.

~/go/src$ go test cmd/go/internal/{modfetch,modload} -count=1
go: finding github.com/rsc/vgotest1 v0.0.0
go: finding github.com/rsc/vgotest1/v2 v2.0.1
go: finding github.com/rsc/vgotest1/v2 v2.0.5
go: finding github.com/pkg/errors v0.8.0
go: finding golang.org/x/text 4e4a3210bb
go: finding gopkg.in/yaml.v2 v2
go: finding vcs-test.golang.org/go/v2module/v2 v2.0.0
go: finding gopkg.in/natefinch/lumberjack.v2 v2.1
go: finding gopkg.in/natefinch/lumberjack.v2 latest
go: finding vcs-test.golang.org/hg/vgotest1.hg/v2 v2.0.4
go: finding gopkg.in/natefinch/lumberjack.v2 v2.0.0-20170531160350-a96e63847dc3
go: finding vcs-test.golang.org/go/mod/gitrepo1 master
go: finding gopkg.in/check.v1 20d25e280405
go: finding vcs-test.golang.org/hg/vgotest1.hg/v2 814fce58e
go: finding gopkg.in/yaml.v2 d670f940
go: finding github.com/rsc/quote/buggy c4d4236f
go: finding github.com/rsc/vgotest1 v1.1.0
go: finding vcs-test.golang.org/hg/vgotest1.hg v1.1.0
2019/05/10 12:49:47 verifying vcs-test.golang.org/go/v2module/[email protected]/go.mod: vcs-test.golang.org/go/v2module/[email protected]/go.mod: reading https://sum.golang.org/lookup/vcs-test.golang.org/go/v2module/[email protected]: 410 Gone
FAIL    cmd/go/internal/modfetch        3.761s
ok      cmd/go/internal/modload 11.964s

@heschi
Copy link
Contributor

heschi commented May 10, 2019

That module is only fetchable with tip Go. The sum DB runs 1.12 and can't get it.

@bcmills
Copy link
Contributor Author

bcmills commented May 10, 2019

That seems like a general usability problem: there will likely always be some modules that the HEAD go command can fetch that the Sum DB cannot.

@heschi
Copy link
Contributor

heschi commented May 10, 2019 •
edited
Loading

In some sense, sure. But I would think that needing to use tip Go is a much more serious usability problem than having to set GONOSUMDB. Anyone who really cares should fix their module, no?

When to upgrade the services' Go version is an open question, but it definitely can't be tracking tip and permanently recording any bugs.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/176538 mentions this issue: cmd/go/internal/modfetch: fix GOSUMDB test failures

@golang golang locked and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @heschi