Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: add command to rebase CLs #31085

Closed
matloob opened this issue Mar 27, 2019 · 3 comments
Closed

x/build/cmd/gopherbot: add command to rebase CLs #31085

matloob opened this issue Mar 27, 2019 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@matloob
Copy link
Contributor

matloob commented Mar 27, 2019

Hi,

I often want to make sure that a change will pass trybots once it's applied to head. It seems like the only way to do that is to rebase the change, and then run trybots. So it would be nice if we could easily rebase CLs on gerrit (we currently need the "Forge Author" permission).

@gopherbot gopherbot added this to the Unreleased milestone Mar 27, 2019
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Mar 27, 2019
@dmitshur
Copy link
Contributor

I often want to make sure that a change will pass trybots once it's applied to head.

We can achieve this either by allowing rebasing, or by making trybots able to do this as part of testing. /cc @bradfitz

@agnivade
Copy link
Contributor

We can achieve this either by allowing rebasing, or by making trybots able to do this as part of testing

That's #9858

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 28, 2019
@dmitshur
Copy link
Contributor

dmitshur commented Sep 13, 2024

Gerrit now provides an ability to rebase on behalf of the original CL author, which doesn't require Forge Author permission. See here. Can you give it a try @matloob?

Optimistically closing this, since I don't expect there's a need to add anything to gopherbot given the new native Gerrit UI.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

6 participants