Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: make TestLoadImportsGraph more robust #30448

Closed
matloob opened this issue Feb 27, 2019 · 1 comment
Closed

x/tools/go/packages: make TestLoadImportsGraph more robust #30448

matloob opened this issue Feb 27, 2019 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@matloob
Copy link
Contributor

matloob commented Feb 27, 2019

@stamblerre

TestLoadImportsGraph makes assumptions on the import graph of the standard library, which is not something that's guaranteed to be stable across Go versions. We've already made two "band-aid" fixes to the test to get it to build, but a better option would be to have the test on a more stable foundation.
@gopherbot gopherbot added this to the Unreleased milestone Feb 27, 2019
@matloob matloob self-assigned this Feb 27, 2019
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Feb 28, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/164298 mentions this issue: go/packages: make TestLoadImportsGraph more stable.

@ianlancetaylor ianlancetaylor mentioned this issue Aug 30, 2019
Closed
@golang golang locked and limited conversation to collaborators Feb 28, 2020
@rsc rsc unassigned matloob Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @matloob