Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: math/big: Rat.SetUint64 #29579

Closed
TuomLarsen opened this issue Jan 5, 2019 · 3 comments
Closed

proposal: math/big: Rat.SetUint64 #29579

TuomLarsen opened this issue Jan 5, 2019 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Proposal Proposal-Accepted
Milestone
Go1.13

Comments

@TuomLarsen
Copy link

Please consider adding Rat.SetUint64 in addition to Rat.SetInt64 as there is currently no way of setting by uint64 integers. This is similar to Int.SetInt64 and Int.SetUint64.
@gopherbot gopherbot added this to the Proposal milestone Jan 5, 2019
@rsc
Copy link
Contributor

rsc commented Jan 9, 2019

Go 1 had Rat.SetInt64 and Int.SetInt64, but then Go 1.1 added Int.SetUint64. At the time we clearly forgot about Rat. This seems fine, and @griesemer agrees.

@rsc rsc modified the milestones: Proposal, Go1.13 Jan 9, 2019
@ianlancetaylor ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 9, 2019
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/160682 mentions this issue: math/big: implement Rat.SetUint64

@TuomLarsen
Copy link
Author

Thank you!

@rsc rsc mentioned this issue Jun 27, 2019
Closed
@golang golang locked and limited conversation to collaborators Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Proposal Proposal-Accepted
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
4 participants
@rsc @TuomLarsen @ianlancetaylor @gopherbot