x/*: define module boundaries for all the repos under golang.org/x/ #28136

dmitris · 2018-10-10T20:04:07Z

@bradfitz -2'ed https://go-review.googlesource.com/c/net/+/141237 with the comment:

Temporary -2 until there's a plan somewhere and linked from here.
I suspect x/net is too broad for one blanket module.

This would be similar to #27858 (which is for x/tools).

It would be great to define the boundaries and set up modules (and tag the code so that it could be used with versions not looking like golang.org/x/net v0.0.0-20181005035420-146acd28ed58 😄

@bcmills - do you know if someone is already working on setting up modules in x/net? if so, could you please include them?

The text was updated successfully, but these errors were encountered:

bcmills · 2018-10-11T14:14:59Z

To summarize the core issues from #27858, the main question to answer here is:

Do the packages in x/net vary in terms of stability, or are they all v0 (unstable), or all v1 (stable)?

(I don't know the answer. CC @mikioh, @bradfitz, @ianlancetaylor, and @tombergan for their opinion.)

bcmills · 2018-10-11T14:16:38Z

Also as noted in #27858 (comment), an existing repository is (de facto) currently a single module: people can already define a go.mod file that refers to it at a particular commit, and if they run go get -u they will expect to have the same packages available.

So I think there's essentially no harm in defining the whole repo as a single module for now.

bradfitz · 2018-10-11T14:45:17Z

@bcmills, that is incredibly sad. I was hoping modules would get us out of this mess and let us carve up x/net and x/tools and let them have their own CI columns, etc. For instance, I'd love it if x/tools/cmd/guru breakages (it breaks all the time) didn't interrupt development of cmd/godoc. And x/net/html has nothing to do with x/net/http2, etc.

rsc · 2018-10-11T17:42:17Z

There needs to be a development of a plan for all the x repos, not a different plan for every repo. I think we should close all these "define module boundaries for one repo at a time" bugs.

dmitris · 2018-10-12T12:52:45Z

@rsc - I renamed the issue to "x/*: define module boundaries for all the repos under golang.org/x/", would it work? If not, feel free to close it.

bcmills · 2019-02-12T22:53:36Z

There needs to be a development of a plan for all the x repos, not a different plan for every repo.

@rsc and I discussed a general strategy for the x/ repos this morning.
My proposal (at least for the 1.13 cycle) is:

Create a go.mod file at the root of each x/ repo, possibly after cleaning up extraneous dependencies (x/tools: clean up dependencies #29981, x/build: reconsider the large number of third-party dependencies #29935).
- Before adding a go.mod file, ensure that the x/ repo is not required at its incorrect github.com/golang module path by any modules that are in the build list of said x/ repo. You can follow the steps described here to check this. This is to avoid regressions such as Unexpected module path lint#436.
Maintain each go.mod file using go mod tidy. Specifically:
- Include all of the dependencies produced by go mod tidy in the go.mod file.
- Encourage the use of go mod tidy when imports are added or removed.
If a specific CL needs to use a new feature or avoid an old bug, it's ok to bump the version of relevant dependencies in the same CL.
It's ok to occasionally run go get -u to upgrade dependencies explicitly, but if the upgrade isn't relevant to a specific other CL, please send it separately. (https://golang.org/cl/145857 is an example of such a change.)
- If the upgrade requires any code fixes, such as to work around incompatible changes, send those fixes in the same CL.
Do not tag explicit releases yet, with the possible exception of x/text (which already has some version tags).
We can revise this strategy as we learn what pain points arise.

bradfitz · 2019-02-12T23:13:52Z

SGTM

gopherbot · 2019-02-13T16:50:15Z

Change https://golang.org/cl/162397 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-14T14:03:35Z

Change https://golang.org/cl/162677 mentions this issue: all: make go.mod consistent with 'go mod tidy'

Updates golang/go#28136 Change-Id: Id72c814ee39931e7f6a1ab421237b8739d8960db Reviewed-on: https://go-review.googlesource.com/c/162677 Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

This change adds a go.mod and go.sum file to the tools repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the tools repository. The tools repo has some extraneous dependencies, but they will be removed soon (we expect a couple of weeks). At that point, our go.sum should shrink to a small handful of entries. Updates golang/go#28136 Change-Id: Ie7802d8d70094a855b112ad0507a47036cb81ba0 Reviewed-on: https://go-review.googlesource.com/c/162397 Run-TryBot: Michael Matloob <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

gopherbot · 2019-02-15T21:55:36Z

Change https://golang.org/cl/162820 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T22:00:29Z

Change https://golang.org/cl/162938 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T22:03:57Z

Change https://golang.org/cl/162912 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T22:13:02Z

Change https://golang.org/cl/162821 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T22:27:10Z

Change https://golang.org/cl/162915 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T22:32:54Z

Change https://golang.org/cl/162916 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T22:40:13Z

Change https://golang.org/cl/162823 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T22:40:32Z

Change https://golang.org/cl/162977 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T22:52:24Z

Change https://golang.org/cl/162825 mentions this issue: all: add a go.mod file

gopherbot · 2019-02-15T23:28:11Z

Change https://golang.org/cl/162911 mentions this issue: all: add a go.mod file

dmitshur · 2019-03-08T16:41:07Z

I have edited @bcmills's #28136 (comment) above to incorporate a minor revision based on what we've learned from golang/lint#436 and #30455.

It adds the "Before adding a go.mod file, ..." sub-bullet point under the first "Create a go.mod file ..." bullet point:

This change adds a go.mod file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. This change does not add a go.sum file because this repo has no dependencies on other repos. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: If06ef87228cd9c8520de9aa457a97947caaaf53f Reviewed-on: https://go-review.googlesource.com/c/time/+/162824 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]>

This change adds a go.mod and go.sum file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. This change also creates a new module with the module path golang.org/x/net/http2/h2demo, and moves the h2demo command into it. This is done by adding a go.mod file in the http2/h2demo directory. As a result, the h2demo command and its dependencies are removed from this and later pseudo-versions of the golang.org/x/net module. The change was generated using Go 1.12. Updates golang/go#28136 Fixes golang/go#30685 Change-Id: Ia5b0f6623c3374355b76106432190a0c9acf3d05 Reviewed-on: https://go-review.googlesource.com/c/net/+/162822 Run-TryBot: Michael Matloob <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

This change adds a go.mod file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. There is no go.sum file because this repo has no dependencies. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: Ie24d8bb73104e8299d3d22cf6c72a295036804f7 Reviewed-on: https://go-review.googlesource.com/c/review/+/162916 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>

This change adds a go.mod file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. This change does not add a go.sum because this repo has no dependencies. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: Ie4f1270a0dfefd4239badf86daa0d7a5b17fd0d5 Reviewed-on: https://go-review.googlesource.com/c/162823 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]>

This change adds a go.mod and go.sum file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: I17b2ac9eaae028a172a5adc260cffba5e0997619 Reviewed-on: https://go-review.googlesource.com/c/162911 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Filippo Valsorda <[email protected]> Reviewed-by: Andrew Bonventre <[email protected]>

This change adds a go.mod and go.sum file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: I837a30c514e23ddab0404a2d8ab66eaa6ad82961 Reviewed-on: https://go-review.googlesource.com/c/162912 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Nigel Tao <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

This change adds a go.mod and go.sum file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. This change also creates a new module with the module path golang.org/x/net/http2/h2demo, and moves the h2demo command into it. This is done by adding a go.mod file in the http2/h2demo directory. As a result, the h2demo command and its dependencies are removed from this and later pseudo-versions of the golang.org/x/net module. The change was generated using Go 1.12. Updates golang/go#28136 Fixes golang/go#30685 Change-Id: Ia5b0f6623c3374355b76106432190a0c9acf3d05 Reviewed-on: https://go-review.googlesource.com/c/net/+/162822 Run-TryBot: Michael Matloob <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>

This change adds a go.mod and go.sum file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: I837a30c514e23ddab0404a2d8ab66eaa6ad82961 Reviewed-on: https://go-review.googlesource.com/c/162912 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Nigel Tao <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

This change adds a go.mod and go.sum file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: I17b2ac9eaae028a172a5adc260cffba5e0997619 Reviewed-on: https://go-review.googlesource.com/c/162911 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Filippo Valsorda <[email protected]> Reviewed-by: Andrew Bonventre <[email protected]>

adonovan · 2024-09-12T17:50:05Z

Is there anything remaining to do here? @dmitshur, feel free to close this.

dmitshur · 2024-09-12T17:55:57Z

Indeed, I think we can consider this done. Thanks.

This change adds a go.mod file to this repo, following the requirements stated in bcmills's comment here: https://golang.org/issue/28136#issuecomment-462971974. It's important to note that we will not be adding versions to the repo for now. This change does not add a go.sum because this repo has no dependencies. The change was generated by running "go mod init" and "go mod tidy" using Go 1.11.5 in the top-level directory of the repository. Updates golang/go#28136 Change-Id: Ie4f1270a0dfefd4239badf86daa0d7a5b17fd0d5 Reviewed-on: https://go-review.googlesource.com/c/162823 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]> Reviewed-by: Bryan C. Mills <[email protected]>

gopherbot added this to the Unreleased milestone Oct 10, 2018

dmitris changed the title ~~x/tools: define module boundaries~~ xnet: define module boundaries Oct 10, 2018

dmitris changed the title ~~xnet: define module boundaries~~ x/net: define module boundaries Oct 10, 2018

bcmills added modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 11, 2018

dmitris changed the title ~~x/net: define module boundaries~~ x/*: define module boundaries for all the repos under golang.org/x/ Oct 12, 2018

thepudds mentioned this issue Oct 25, 2018

x/all: start tagging versions #21324

Closed

myitcv mentioned this issue Nov 7, 2018

cmd/go: go mod fails to find direct dependencies #28629

Closed

jeanbza mentioned this issue Nov 7, 2018

internal: add go.mod and go.sum file googleapis/go-genproto#111

Merged

dmitshur mentioned this issue Mar 16, 2019

Add go.mod dominikh/go-tools#346

Closed

rhcarvalho mentioned this issue Feb 4, 2020

Split sentry-go into multiple submodules getsentry/sentry-go#156

Closed

dmitshur mentioned this issue Oct 7, 2020

x/build: use new name for release branches in golang.org/x repos starting with Go 1.16 #36882

Closed

dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Sep 12, 2024

dmitshur closed this as completed Sep 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/*: define module boundaries for all the repos under golang.org/x/ #28136

x/*: define module boundaries for all the repos under golang.org/x/ #28136

dmitris commented Oct 10, 2018 •

edited

Loading

bcmills commented Oct 11, 2018

bcmills commented Oct 11, 2018

bradfitz commented Oct 11, 2018

rsc commented Oct 11, 2018

dmitris commented Oct 12, 2018 •

edited

Loading

bcmills commented Feb 12, 2019 •

edited by dmitshur

Loading

bradfitz commented Feb 12, 2019

gopherbot commented Feb 13, 2019

gopherbot commented Feb 14, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

dmitshur commented Mar 8, 2019

adonovan commented Sep 12, 2024

dmitshur commented Sep 12, 2024

x/*: define module boundaries for all the repos under golang.org/x/ #28136

x/*: define module boundaries for all the repos under golang.org/x/ #28136

Comments

dmitris commented Oct 10, 2018 • edited Loading

bcmills commented Oct 11, 2018

bcmills commented Oct 11, 2018

bradfitz commented Oct 11, 2018

rsc commented Oct 11, 2018

dmitris commented Oct 12, 2018 • edited Loading

bcmills commented Feb 12, 2019 • edited by dmitshur Loading

bradfitz commented Feb 12, 2019

gopherbot commented Feb 13, 2019

gopherbot commented Feb 14, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

gopherbot commented Feb 15, 2019

dmitshur commented Mar 8, 2019

adonovan commented Sep 12, 2024

dmitshur commented Sep 12, 2024

dmitris commented Oct 10, 2018 •

edited

Loading

dmitris commented Oct 12, 2018 •

edited

Loading

bcmills commented Feb 12, 2019 •

edited by dmitshur

Loading