Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: ask trybots to submit on pass #22123

Closed
crawshaw opened this issue Oct 3, 2017 · 1 comment
Closed

x/build: ask trybots to submit on pass #22123

crawshaw opened this issue Oct 3, 2017 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Unreleased

Comments

@crawshaw
Copy link
Member

crawshaw commented Oct 3, 2017

Right now we +1 trybots on gerrit to run the trybots.

We could have a feature where we +2 trybots and have the bots submit the CL when it passes. A human reviewer would have to have already +2ed the CL.

This is a potential alternative to #12482. It's less invasive, because instead of the reviewer triggering the submission, the author triggers it.

(We have this feature on fuchsia's gerrit and it is very useful.)
@gopherbot gopherbot added this to the Unreleased milestone Oct 3, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 3, 2017
@bradfitz bradfitz mentioned this issue Nov 14, 2017
Closed
@ALTree ALTree added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Oct 3, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Apr 3, 2019

Dup of #12482 (from two years prior)

@bradfitz bradfitz closed this as completed Apr 3, 2019
@golang golang locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @crawshaw @ALTree @gopherbot