-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: update NetBSD builders to NetBSD 8-beta #20852
Comments
This should also be fixed in the 7.1 branch now, builds available from: |
I would be more comfortable with a netbsd-8 system than with 7.1. http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=52034 is still pending, and it means that significant disk activity is likely to crash the VM, or make it hang. |
CL https://golang.org/cl/48091 mentions this issue. |
There have been a number of fixes for issues found with the Go test suite in kqueue, signal handling and vio drivers. Updates golang/go#20852 Change-Id: I95861220990c05f3e89a4a40893e17758d29ebe0 Reviewed-on: https://go-review.googlesource.com/48091 Reviewed-by: Brad Fitzpatrick <[email protected]>
CL https://golang.org/cl/48552 mentions this issue. |
@bsiegert, this doesn't boot on GCE as far as I can tell:
Please let me know once you've actually run it on GCE. Until that time, Go will continue to not run NetBSD builders. |
I didn't mean to close this. Reopened. |
Are there any log messages on how -8 fails to boot on GCE, or are there any GCE hosts available for us to try? |
I didn't have time to capture the serial console. I had assumed @bsiegert tested this. You can create small GCE VM instances yourself for free: https://cloud.google.com/free/ |
The relevant bit from the serial console:
The binary packages are for NetBSD-7, and I suppose they are linked against base OpenSSL from NetBSD-7 :( Sorry for not catching this before sending out the CL. |
Yes, it is unfortunate that there are no pre-built packages for -8 yet. I will work on that. Do you need anything else from me? |
I'll try unpacking a /lib and /usr/lib from NetBSD-7 to fix this. |
the better way is to make the symlinks to the missing shared libraries to point to the new ones... |
@zoulasc That sounds unsafe if there was a major bump in between. |
CL https://golang.org/cl/49670 mentions this issue. |
it is not an issue, people were just being conservative with libcrypto. OTOH if you replace libraries with older versions every binary on the system will break. But no worries, I'll have packages built soon. |
Change https://golang.org/cl/53010 mentions this issue: |
This should fix the latest set of errors that bradfitz@ was seeing. Updates golang/go#20852 Change-Id: Iad7d6a479c5546395de907731643c1d817fe625d Reviewed-on: https://go-review.googlesource.com/53010 Reviewed-by: Brad Fitzpatrick <[email protected]>
@bsiegert, it still doesn't work. Logs from the new x/build/cmd/debugnewvm tool running https://gist.github.com/bradfitz/3a6ba42ed3f9d7a47338e2172cfab9bb |
Thanks for testing, and thanks for making me aware of It appears that this time, there has been a regression around setting routes. There is a default route via .0.1 but the host route to .0.1 is missing for some reason. |
It took me a long time to find out, but it is a small bug in dhcpcd, the DHCP client. I will get this fix into NetBSD-8, then try again. |
@bsiegert, I just rebuilt the 386 image. It boots saying
I'll try again tomorrow. |
https://releng.netbsd.org/cgi-bin/req-8.cgi just monitor 413. Martin who committed the fix cannot pullup it and we need another person from releng to test and merge the patch. |
@krytarowski, thanks for the info & link! |
Change https://golang.org/cl/81356 mentions this issue: |
…tbsd-386 Fixes golang/go#22872 Updates golang/go#20852 Change-Id: I2b3454cb59a434cb12b10bb93cb4dd21d5187281 Reviewed-on: https://go-review.googlesource.com/81356 Reviewed-by: Andrew Bonventre <[email protected]>
Change https://golang.org/cl/81735 mentions this issue: |
Updates golang/go#22968 Updates golang/go#20852 Change-Id: Ida2bc7213d418735e897d0bae8e5fba9ae18fd6c Reviewed-on: https://go-review.googlesource.com/81735 Reviewed-by: Brad Fitzpatrick <[email protected]>
@bsiegert, the NetBSD/386 VM now boots on GCE, but I can't find any NetBSD mirror with binary packages for i386, which means we have no curl and we can't download the buildlet. The builder script fails on these lines, https://github.com/golang/build/blob/master/env/netbsd-amd64/mkvm.py#L63 But doesn't stop building the VM image on error.
Does somebody build i386 packages? Or do we need to build from source? (That's what I did on my test NetBSD/i386 VM, but it was super tedious and involved checking out all of the pkgsrc cvs repo.... I'd rather not do that all in qemu) |
We need to rebuild the packages for NetBSD-8/i386. I've noted execution of "race" tests for FreeBSD, Linux, Windows - is this ThreadSanitizer (TSan) related? If so, we could add a NetBSD/amd64 target. |
@krytarowski, who rebuilds packages? When can that be done by? As for race detector support, that's unrelated to this issue. There is at least #19273 open for more platform support. Or you could file a new bug. But it would likely require upstream TSAN support. It won't happen for Go 1.10. |
We, have already passed the requests internally to responsible developers.If I recall correctly, Manuel Bouyer was generating them.. however -current branches (like -8) are special cases so they will be generated on demand. |
Oh, you already ported TSAN (https://blog.netbsd.org/tnf/entry/one_year_checkpoint_and_thread). Feel free to file a new bug for tracking Go support. |
I am trying to build i386 packages for NetBSD-8.0... |
Change https://golang.org/cl/82018 mentions this issue: |
Also update the bootstrap toolchain (verified in VMware VM locally). Updates golang/go#20852 Change-Id: Iac875419ed8dc51fb9db09d8948067f24c601e17 Reviewed-on: https://go-review.googlesource.com/82018 Reviewed-by: Andrew Bonventre <[email protected]>
There should be packages now for 8.0 + i386. Please let me know if I missed any dependencies. |
@zoulasc, I don't seen http://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/i386/8.0_2017Q3/All/ The complete set we try to install is:
But emacs, vim, screen, go14, and even git-base should be optional. They're more nice-to-have for debugging. But without mozilla-rootcerts, curl & Go might have issues fetching resources. |
stay tuned :-) |
you should have everything but emacs... which should come later. |
@zoulasc, thanks. I'm kicking off a build of the image. |
thank you for all your patience :-) I am building git now. |
Change https://golang.org/cl/82019 mentions this issue: |
The necessary binary packages are now available at: http://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/i386/8.0_2017Q3/All/ Updates golang/go#20852 Change-Id: I20660a29f9e4044899de75d1b632c34619fca19b Reviewed-on: https://go-review.googlesource.com/82019 Reviewed-by: Brad Fitzpatrick <[email protected]>
Okay, deployed. I have it configured to only use 1 VM at a time so it won't use our self-imposed 500 VM quota all at once to catch up, but it'll catch up slowly on its own. I ran one test build manually and watched it get through the start, so I see networking on GCE now works, and bash & curl work, the buildlet starts (I needed to rebuild it for the sysctl fix), and make.bash starts running. I assume it'll be fine. Famous last words. Off to sleep... Thanks again, @zoulasc and @bsiegert and @krytarowski! |
Thanks for your effort! The next release should ship with TSan, MSan and ARM CI machines on NetBSD! |
Really impressed with all the collaboration on this effort. Nice work, everyone! 🎉 |
And looks good this morning. Still some flakes here & there, but much better. I'm going to close this bug. We can open new ones for specific issues that come up. |
In https://go-review.googlesource.com/c/47036/, Christos Zoulas mentions that there are known bugs in the NetBSD 7.1 kqueue code and we should switch our builders to NetBSD 8-beta.
Also mentioned in #20836 (comment)
This is a tracking bug to update our NetBSD builders past 7.1
I've updated https://golang.org/wiki/MinimumRequirements too.
/cc @krytarowski @bsiegert @zoulasc @adams-sarah @andybons
The text was updated successfully, but these errors were encountered: