Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/exec: flaky TestStdinCloseRace #19211

Closed
bradfitz opened this issue Feb 21, 2017 · 6 comments
Closed

os/exec: flaky TestStdinCloseRace #19211

bradfitz opened this issue Feb 21, 2017 · 6 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.8.1

Comments

@bradfitz
Copy link
Contributor

https://build.golang.org/log/638ade578f749a07444424d53c92a64681559411

PASS
panic: Fail in goroutine after  has completed

goroutine 21 [running]:
testing.(*common).Fail(0xc420074f70)
	/tmp/workdir/go/src/testing/testing.go:445 +0x179
testing.(*common).Fail(0xc4201220d0)
	/tmp/workdir/go/src/testing/testing.go:439 +0x1b0
testing.(*common).Errorf(0xc4201220d0, 0x8927f0, 0x8, 0xc42001e7b0, 0x1, 0x1)
	/tmp/workdir/go/src/testing/testing.go:518 +0x95
os/exec_test.TestStdinCloseRace.func1(0xc420124160, 0xc4201220d0)
	/tmp/workdir/go/src/os/exec/exec_test.go:267 +0xf6
created by os/exec_test.TestStdinCloseRace
	/tmp/workdir/go/src/os/exec/exec_test.go:265 +0x261
FAIL	os/exec	2.210s
@bradfitz bradfitz added help wanted Testing An issue that has been verified to require only test changes, not just a test failure. labels Feb 21, 2017
@bradfitz bradfitz added this to the Go1.9 milestone Feb 21, 2017
@alexbrainman
Copy link
Member

Probably unrelated, but if I run this test 100 times, like

go test -v -c -o a.exe os/exec && for /l %x in (1, 1, 100) do a.exe -test.run=TestStdinCloseRace

it usually fails couple of times with:

--- FAIL: TestStdinCloseRace (0.01s)
        exec_test.go:282: Wait: succeeded unexpectedly
FAIL

only on my Windows XP 32-bit, never on Windows 7 64-bit.

My failure is, probably, related to #17245.

Alex

@mvdan mvdan mentioned this issue Feb 21, 2017
Closed
@ianlancetaylor ianlancetaylor modified the milestones: Go1.8.1, Go1.9 Feb 21, 2017
@ianlancetaylor
Copy link
Member

ianlancetaylor commented Feb 21, 2017 •
edited
Loading

Setting milestone to 1.8.1 since the fix is trivial and test-only and the problem has been reported by people trying to build 1.8 (in #19213).

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/37309 mentions this issue.

@ianlancetaylor
Copy link
Member

Reopening to consider merging the CL to 1.8.1.

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/38607 mentions this issue.

gopherbot pushed a commit that referenced this issue Mar 25, 2017
@ianlancetaylor @bradfitz
[release-branch.go1.8] os/exec: deflake TestStdinCloseRace
f8ed453 
Stop reporting errors from cmd.Process.Kill; they don't matter for
purposes of this test, and they can occur if the process exits quickly.

Fixes #19211.
Fixes #19213.

Change-Id: I1a0bb9170220ca69199abb8e8811b1dde43e1897
Reviewed-on: https://go-review.googlesource.com/37309
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
(cherry picked from commit 35ffca3)
Reviewed-on: https://go-review.googlesource.com/38607
Run-TryBot: Brad Fitzpatrick <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@rsc
Copy link
Contributor

rsc commented Apr 5, 2017

Cherry-picked to release branch. Closing.

@rsc rsc closed this as completed Apr 5, 2017
@golang golang locked and limited conversation to collaborators Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.8.1
Development

No branches or pull requests
6 participants
@bradfitz @rsc @aclements @ianlancetaylor @gopherbot @alexbrainman