Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: test fails when GOBIN is set #14901

Closed
crawshaw opened this issue Mar 21, 2016 · 4 comments
Closed

net/http: test fails when GOBIN is set #14901

crawshaw opened this issue Mar 21, 2016 · 4 comments
Milestone

Comments

@crawshaw
Copy link
Member

$ export GOBIN=$HOME
$ go test net/http
--- FAIL: TestCmdGoNoHTTPServer (0.06s)
    http_test.go:79: go tool nm: exit status 1
FAIL
FAIL    net/http    0.104s
$

cc @bradfitz

@crawshaw crawshaw added this to the Go1.7 milestone Mar 21, 2016
@gopherbot
Copy link
Contributor

CL https://golang.org/cl/20967 mentions this issue.

@bradfitz
Copy link
Contributor

But now this broke me again for the opposite reason: The go binary in my $PATH is a script which uses the right go binary for the GOROOT I'm currently testing:

bradfitz@laptop http$ which go
/Users/bradfitz/bin/go
bradfitz@laptop http$ cat $HOME/bin/go
#!/bin/sh

exec $GOROOT/bin/go "$@"

@bradfitz bradfitz reopened this Mar 30, 2016
@bradfitz
Copy link
Contributor

And the error locally:

bradfitz@laptop http$ go test -v -run=TestCmdGoNoHTTPServer
=== RUN   TestCmdGoNoHTTPServer
--- FAIL: TestCmdGoNoHTTPServer (0.08s)
        http_test.go:71: go tool nm: exit status 1: open /Users/bradfitz/bin/go: unrecognized object file
FAIL
exit status 1
FAIL    net/http        0.126s

@gopherbot
Copy link
Contributor

CL https://golang.org/cl/21292 mentions this issue.

@golang golang locked and limited conversation to collaborators Mar 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants