From 97b04152bc3d9df1155bc97d9e6095f69b6882c7 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Tue, 18 Oct 2016 21:42:09 +0000 Subject: [PATCH] net/http: update test to check Content-Length 0 Body more reliably The way to send an explicitly-zero Content-Length is to set a nil Body. Fix this test to do that, rather than relying on type sniffing. Updates #17480 Updates #17071 Change-Id: I6a38e20f17013c88ec4ea69d73c507e4ed886947 Reviewed-on: https://go-review.googlesource.com/31434 TryBot-Result: Gobot Gobot Run-TryBot: Brad Fitzpatrick Reviewed-by: Chris Broadfoot --- src/net/http/clientserver_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/http/clientserver_test.go b/src/net/http/clientserver_test.go index 53e0be680bb89c..f55242418976ec 100644 --- a/src/net/http/clientserver_test.go +++ b/src/net/http/clientserver_test.go @@ -468,7 +468,7 @@ func TestH12_RequestContentLength_Known_NonZero(t *testing.T) { } func TestH12_RequestContentLength_Known_Zero(t *testing.T) { - h12requestContentLength(t, func() io.Reader { return strings.NewReader("") }, 0) + h12requestContentLength(t, func() io.Reader { return nil }, 0) } func TestH12_RequestContentLength_Unknown(t *testing.T) {