From 8f6a9acbb3f63a77175eaa153cace5f3b6d611b2 Mon Sep 17 00:00:00 2001 From: Michael Anthony Knyszek Date: Fri, 8 Jan 2021 16:56:24 +0000 Subject: [PATCH] runtime/metrics: remove unused StopTheWorld Description field This change removes the as-of-yet unused StopTheWorld field in the Description struct. Adding a new field to a struct is much easier than removing it, so let's save it for when we actually need it. Change-Id: I8074b8569187c1a148500575fa8a661534e875d5 Reviewed-on: https://go-review.googlesource.com/c/go/+/282632 Run-TryBot: Michael Knyszek TryBot-Result: Go Bot Trust: Michael Knyszek Reviewed-by: Michael Pratt Reviewed-by: Austin Clements --- api/go1.16.txt | 1 - src/runtime/metrics/description.go | 4 ---- 2 files changed, 5 deletions(-) diff --git a/api/go1.16.txt b/api/go1.16.txt index baac5379f81e51..8a8c6b8860cd21 100644 --- a/api/go1.16.txt +++ b/api/go1.16.txt @@ -395,7 +395,6 @@ pkg runtime/metrics, type Description struct, Cumulative bool pkg runtime/metrics, type Description struct, Description string pkg runtime/metrics, type Description struct, Kind ValueKind pkg runtime/metrics, type Description struct, Name string -pkg runtime/metrics, type Description struct, StopTheWorld bool pkg runtime/metrics, type Float64Histogram struct pkg runtime/metrics, type Float64Histogram struct, Buckets []float64 pkg runtime/metrics, type Float64Histogram struct, Counts []uint64 diff --git a/src/runtime/metrics/description.go b/src/runtime/metrics/description.go index 01c8a685ee6825..716802e9a2f9fe 100644 --- a/src/runtime/metrics/description.go +++ b/src/runtime/metrics/description.go @@ -46,10 +46,6 @@ type Description struct { // // This flag thus indicates whether or not it's useful to compute a rate from this value. Cumulative bool - - // StopTheWorld is whether or not the metric requires a stop-the-world - // event in order to collect it. - StopTheWorld bool } // The English language descriptions below must be kept in sync with the