Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Test-only dependencies are not being considered by dep #306

Closed
andreynering opened this issue Mar 8, 2017 · 2 comments
Closed

Test-only dependencies are not being considered by dep #306

andreynering opened this issue Mar 8, 2017 · 2 comments

Comments

@andreynering
Copy link

In a project one may have dependencies imported only by tests. These dependencies are not being added to manifest.json, lock.json or to vendor/ folder. I think most people would expect these deps to be added, too.

Deps' test dependencies don't need to be vendored, only root project's test deps.

@sdboyer
Copy link
Member

sdboyer commented Mar 10, 2017

I can't reproduce this. When I add a unique import to a *_test.go file and run dep ensure, it shows up in both the lock.json and vendor/.

Could you provide some more detailed steps for reproduction?

@andreynering
Copy link
Author

I could not reproduce anymore after updating dep.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants