From d0683749729372f8c95b8c371623f3cdd22f8781 Mon Sep 17 00:00:00 2001 From: Dale Hui Date: Sun, 18 Aug 2019 18:38:13 -0700 Subject: [PATCH] Test against MS SQL Server 2019-CTP3.1 (Ubuntu) --- database/sqlserver/README.md | 9 ++++++++- database/sqlserver/sqlserver_test.go | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/database/sqlserver/README.md b/database/sqlserver/README.md index 58a833e39..86a0b79f7 100644 --- a/database/sqlserver/README.md +++ b/database/sqlserver/README.md @@ -19,7 +19,14 @@ See https://github.com/denisenkom/go-mssqldb for full parameter list. -## Note about driver support +## Driver Support + +### Which go-mssqldb driver to us? Please note that the deprecated `mssql` driver is not supported. Please use the newer `sqlserver` driver. See https://github.com/denisenkom/go-mssqldb#deprecated for more information. + +### Official Support by migrate + +Versions of MS SQL Server 2019 newer than CTP3.1 are not officially supported since there are issues testing against the Docker image. +For more info, see: https://github.com/golang-migrate/migrate/issues/160#issuecomment-522433269 diff --git a/database/sqlserver/sqlserver_test.go b/database/sqlserver/sqlserver_test.go index a4844ad0b..08f7fb67f 100644 --- a/database/sqlserver/sqlserver_test.go +++ b/database/sqlserver/sqlserver_test.go @@ -30,7 +30,7 @@ var ( // Container versions: https://mcr.microsoft.com/v2/mssql/server/tags/list specs = []dktesting.ContainerSpec{ {ImageName: "mcr.microsoft.com/mssql/server:2017-latest-ubuntu", Options: opts}, - {ImageName: "mcr.microsoft.com/mssql/server:2019-latest", Options: opts}, + {ImageName: "mcr.microsoft.com/mssql/server:2019-CTP3.1-ubuntu", Options: opts}, } )