Fix issue with built-in function #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiopramayudi
requested review from
pradithya and
karzuo
and removed request for
pradithya
|
Can you add test that will catch this issue in https://github.com/gojek/merlin/blob/d5f9a3b63fcc7e84d1bd3a43e9eda93f68b53460/api/pkg/transformer/server/server_test.go#L146 . This test cover standard transformer behavior almost end to end, so I would like to use it to minimise number of end to end test / manual test. |
pradithya
reviewed
Apr 14, 2022
pradithya
reviewed
Apr 14, 2022
done |
pradithya
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Fix issue when dealing with expr built-in function * Update server test Co-authored-by: Tio Pramayudi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We faced issue when dealing with expr built function, such as
filter,map,none,all, andany. This is because we override arithmetic and comparator operation. The override operation will register the operation and evaluate later, this is due to subset operation for series, but for operation between primitive types (int, bool, string, float) we can evaluate the value immediately. Hence the fix, will evaluate the value of operation between primitive types immediatelyWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Checklist