Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test #220

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Fix integration test #220

merged 4 commits into from
Feb 14, 2022

Conversation

karzuo
Copy link
Contributor

@karzuo karzuo commented Feb 11, 2022

What this PR does / why we need it:
Fix integration test for cyclical encoder

Checklist

  • [x ] Added unit test, integration, and/or e2e tests
  • [x ] Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduce API changes

@karzuo karzuo requested a review from pradithya February 11, 2022 18:04
@karzuo karzuo self-assigned this Feb 11, 2022
pradithya
pradithya approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@pradithya pradithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradithya pradithya merged commit 6bbe736 into main Feb 14, 2022
@pradithya pradithya deleted the fix-int-test-cyclic branch February 14, 2022 02:01
pradithya pushed a commit that referenced this pull request Oct 3, 2022
Fix integration test (#220)
bca5b69 
* fix integration test data mistake

* edit test to allow tolerances in float

* fix assert

* fix assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradithya pradithya pradithya approved these changes

Assignees

@karzuo karzuo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karzuo @pradithya