Emit metric for redis and bigtable client #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiopramayudi
changed the title
pradithya
reviewed
Jan 21, 2022
| Help: "Redis connection stats", | ||
| }, []string{"stat"}) | ||
|
|
||
| hitConnStats = "hits" |
There was a problem hiding this comment.
Use constant instead of var
pradithya
reviewed
Jan 21, 2022
| } | ||
|
|
||
| func (h *redisHook) AfterProcess(ctx context.Context, cmd redis.Cmder) error { | ||
| startTime, ok := ctx.Value(requestStartKey{}).(time.Time) |
There was a problem hiding this comment.
How will it be able to calculate the latency? It doesn't seem to be the case here
There was a problem hiding this comment.
before running the redis command, it will create new context that add start time of the command, this part of BeforeProcess
pradithya
pushed a commit
that referenced
this pull request
Oct 3, 2022
* Add metric for redis and bigtable direct serving * Check whether pool stats for redis nil or not * Make status string as const instead of var * Remove bigtable grpc metric Co-authored-by: Tio Pramayudi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Emit redis & bigtable client metric for better observability of feast direct serving
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Checklist