Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-cloud-sdk version #206

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Update google-cloud-sdk version #206

merged 2 commits into from
Jan 6, 2022

Conversation

pradithya
Copy link
Member

@pradithya pradithya commented Jan 6, 2022

What this PR does / why we need it:

Latest miniconda3 image removed python2 interpreter which causes following error in google-cloud-sdk

(base) root@5b4abe2bb536:/# gsutil --version
Traceback (most recent call last):
  File "/google-cloud-sdk/bin/bootstrapping/gsutil.py", line 13, in <module>
    import bootstrapping
  File "/google-cloud-sdk/bin/bootstrapping/bootstrapping.py", line 32, in <module>
    import setup  # pylint:disable=g-import-not-at-top
  File "/google-cloud-sdk/bin/bootstrapping/setup.py", line 55, in <module>
    from googlecloudsdk.core.util import platforms
  File "/google-cloud-sdk/lib/googlecloudsdk/__init__.py", line 23, in <module>
    from googlecloudsdk.core.util import importing
  File "/google-cloud-sdk/lib/googlecloudsdk/core/util/importing.py", line 23, in <module>
    import imp
  File "/opt/conda/lib/python3.9/imp.py", line 23, in <module>
    from importlib import util
  File "/opt/conda/lib/python3.9/importlib/util.py", line 2, in <module>
    from . import abc
  File "/opt/conda/lib/python3.9/importlib/abc.py", line 17, in <module>
    from typing import Protocol, runtime_checkable
  File "/opt/conda/lib/python3.9/typing.py", line 26, in <module>
    import re as stdlib_re  # Avoid confusion with the re we export.
  File "/opt/conda/lib/python3.9/re.py", line 124, in <module>
    import enum
  File "/google-cloud-sdk/lib/third_party/enum/__init__.py", line 26, in <module>
    spec = importlib.util.find_spec('enum')

The google-cloud-sdk that we use doesn't support Python 3.9.5 (default python interpreter in the latest miniconda3 image), hence the upgrade.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


Checklist

  • Tested locally

@pradithya pradithya requested a review from tiopramayudi January 6, 2022 07:14
@pradithya pradithya self-assigned this Jan 6, 2022
@tiopramayudi
Copy link
Collaborator

lgtm

Copy link
Contributor

@ariefrahmansyah ariefrahmansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with nit comment

python/pyfunc-server/base.Dockerfile Show resolved Hide resolved
@pradithya pradithya merged commit 025699d into main Jan 6, 2022
@pradithya pradithya deleted the gcloud_sdk branch January 6, 2022 07:59
pradithya pushed a commit that referenced this pull request Oct 3, 2022
* Update google-cloud-sdk version

* Update local.Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants