Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yaml specification on feast standard transformer page #205

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

tiopramayudi
Copy link
Collaborator

What this PR does / why we need it:

Fix issue on how ui render standard transformer yaml spec when user use jsonPath instead of jsonPathConfig. The issue is happening on :

  • variable declaration. Currently it showing jsonPath field instead of jsonPathConfig
  • feast entity. Currently showing both jsonPath and jsonPathConfig where the expected is only jsonPathConfig
    Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Before:
Screen Shot 2022-01-05 at 15 32 06

After:
Screen Shot 2022-01-05 at 16 38 27


Checklist

  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduce API changes

…thConfig' field instead of only 'jsonPathConfig'
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tiopramayudi tiopramayudi merged commit 31357c8 into main Jan 5, 2022
@tiopramayudi tiopramayudi deleted the fix-ui-jsonpath branch January 5, 2022 23:21
pradithya pushed a commit that referenced this pull request Oct 3, 2022
…thConfig' field instead of only 'jsonPathConfig' (#205)

Co-authored-by: Tio Pramayudi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants