RemovedInDjango110Warning: SubfieldBase has been deprecated

[autogestion]

Django 1.9 throws such warning:

.../lib/python3.4/site-packages/django/db/models/fields/subclassing.py:22: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.

SubfieldBase is used here

django-multiselectfield/multiselectfield/db/fields.py

Line 135 in c232d17

MultiSelectField = add_metaclass(models.SubfieldBase)(MultiSelectField)

[morocarlo]

anyone know who to fix it?

[tammyalexandra]

+1

[im-n1]

+1

[jenlu]

Hi, here is an attempt at a fix that in some ways reverts to using strings that perhaps can inspire someone to add this to the code. Seems like just keeping the to_python and from_db_value to return lists will mess up how values() and values_lists() works on query sets:

(1) delete the subfieldbase referens, as not needed anymore
(2) ensure to_python() returns a list (but accepts strings, lists, None)
(3) ensure from_db_value() returns a string
(4) change in contribute_to_class() so the iteration accepts a string and splits this into a list

def contribute_to_class(self, cls, name):

    super(MultiSelectField, self).contribute_to_class(cls, name)
    if self.choices:
        def get_list(obj):
            fieldname = name
            choicedict = dict(self.choices)
            display = []

            if getattr(obj, fieldname):
                # for value in getattr(obj, fieldname):
                for value in getattr(obj, fieldname).split(','):
                    item_display = choicedict.get(value, None)
                    if item_display is None:
                        try:
                            item_display = choicedict.get(int(value), value)
                        except (ValueError, TypeError):
                            item_display = value
                    display.append(string_type(item_display))
            return display

        def get_display(obj):
            return ", ".join(get_list(obj))

        setattr(cls, 'get_%s_list' % self.name, get_list)
        setattr(cls, 'get_%s_display' % self.name, get_display)

(5) in MultiSelectFormField add/override prepare_value() so it returns a list

class MultiSelectFormField(forms.MultipleChoiceField):

def prepare_value(self, value):
    '''
        Override prepare_value to convert string to list, so it can be used
    '''
    if value==None or value=='':
        return []
    elif isinstance(value, list):
        return value
    elif isinstance(value, basestring):
        return value.split(",") 

[drernie]

+1

[drernie]

Appears to be blocked by #40

[autogestion]

Looks like adding

def from_db_value(self, value, expression, connection, context):
    return self.to_python(value)

and removing

MultiSelectField = add_metaclass(models.SubfieldBase)(MultiSelectField)

fix the problem

#40 .values_list() works fine

Django==1.9.5

[im-n1]

Great work there!

Can someone please update the repo and release new version?

Thank in advance.

[platzhersh]

what's the status here? Would offer help to close this matter

[im-n1]

I guess the only solution is fork the project, name it "django-multiselectfield-updated" and release it on PyPy.
The origin author is probably dead :)

[Sergiy-Solomka]

Did what autogestion commented, and look like its work good... I am sure will be grate if somebody can update the project, thanks..

[lorinkoz]

@autogestion, I would recommend a couple of changes in your code:

def from_db_value(self, value, expression, connection, context):
    if value is None:
        return value
    return self.to_python(value)

and instead of removing the metaclass, add a Django version check for backwards compatibility (the deprecation was introduced in Django 1.8):

if django.VERSION[0] = 1 and django.VERSION[1] < 8:
    MultiSelectField = add_metaclass(models.SubfieldBase)(MultiSelectField)

[blag]

I'm the new maintainer. I'll try to get to this soon, right now I'm expanding the tests to tests with Django 1.8+. If I forget to fix this, feel free to ping me.

[blag]

@platzhersh: If you have the time and inclination to help, get this into a mergeable and test-passable PR for me and I'll merge it in.

[blag]

Thanks to @lorinkoz's PR #47, this is now in master. I'll try to cut a PyPI release today or tomorrow.

Closing.

[blag]

Version 0.1.4 has just been pushed to PyPI, and includes this fix.