Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JS (and possibly also in the future CSS, SCSS) imports to resolve relative to the content bundle #12876

Open
bep opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@bep
Copy link
Member

bep commented Sep 24, 2024

Working on #12641 it's now (or when that is merged) already possible to include page bundled JS resources in a JS bundle built by ESBuild.

It's also possible to import CSS files, which will be bundled in a separate CSS file.

As of writing this, these CSS imports will be resolved in /assets only. But it would obviously be useful if we also could resolve relative to the content bundle itself:

content
├── _index.md
└── components
    ├── _index.md
    └── dialog
        ├── dialog.css
        ├── dialog.jsx
        └── index.md

Note to self: To get the dependency tracking working when running in server/watch mode, we cannot resolve on the file system; we need to resolve in Page.Resources.

@bep bep added the Proposal label Sep 24, 2024
@bep bep added this to the v0.135.0 milestone Sep 24, 2024
@bep bep self-assigned this Sep 24, 2024
@bep bep pinned this issue Sep 24, 2024
@bep bep modified the milestones: v0.135.0, v0.136.0 Sep 28, 2024
@bep bep modified the milestones: v0.136.0, v0.137.0, v0.138.0 Oct 23, 2024
@bep bep modified the milestones: v0.138.0, v0.139.0 Nov 6, 2024
@bep bep modified the milestones: v0.139.0, v0.140.0 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant