querify doesn't encode single quotes correctly

[ys]

What version of Hugo are you using (hugo version)? 0.120.4

Does this issue reproduce with the latest release? Yes

When doing querify "lol" .Summary on a page with a summary: Mon labo me le disait, y’a quelque chose de bizarre dans tes expositions.

The encoded string is lol=Mon+labo+me+le+disait%2C+y%26rsquo%3Ba+quelque+chose+de+bizarre+dans+tes+expositions.

%26rsquo%3B which is ’ but should be %27. Which is the correct way to URL encode apostrophe or single quote I think.

[jmooring]

On this page, how is the summary defined? Automatically, manually (using <!--more-->), or in front matter?

[ys]

Manually as you can check on https://github.com/ys/bonjour/blob/main/content/posts/revision-leica/index.md?plain=1

[ys]

Usage of the querify can be seen in https://github.com/ys/bonjour/blob/main/themes/simple/layouts/partials/opengraph.html#L9

And result is at https://yannickschutz.com/revision-leica/

[ys]

I just tested url.Values encode method on https://pkg.go.dev/net/url#Values.Encode and it correctly encode it to %27

[jmooring]

The problem you are experiencing is closely related to #8910 (comment). Regardless of how you define the summary, it is passed through the markdown renderer, which converts certain punctuation characters to HTML entities.

The querify function is behaving as expected/desired. For example:

{{ querify "a" "b'c" }} --> a=b%27c 

Option 1

For a summary defined in front matter, you can access the raw value with:

{{ querify "lol" .Params.Summary }}

But I'm not sure how forward-compatible that's going to be. See #11055.

Option 2

Change the character substitution rules in your site configuration:

[markup.goldmark.extensions.typographer]
apostrophe = "'"
leftSingleQuote = "'"
rightSingleQuote = "'"

Option 3

Disable the typographer extension:

[markup.goldmark.extensions.typographer]
disable = true

Option 4

Use a different front matter field, such as description:

{{ querify "lol" .Description }}

To summarize, the querify function encodes single quotes correctly. The problem is that your code is feeding it an HTML entity.

[ys]

Wow, thanks so much, it makes a lot more sense then... Will pick an option.
Thanks for the many ones!

Glad it is me and not the code...

[ys]

It looks like that .Description suffers a similar fate... it ends up as %26%2339%3B

[ys]

Nevermind, it is because I use truncate...

[jmooring]

{{ querify "a" ("b'c" | safeHTML | truncate 42) }}

https://gohugo.io/functions/strings/truncate/

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.