Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add creator for robot #20846

Merged
merged 4 commits into from
Aug 15, 2024
Merged

add creator for robot #20846

merged 4 commits into from
Aug 15, 2024

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Aug 13, 2024

add the creator for robot creation

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (c8c11b4) to head (2fbc138).
Report is 262 commits behind head on main.

Files Patch % Lines
src/server/v2.0/handler/robot.go 0.00% 5 Missing ⚠️
src/server/v2.0/handler/model/robot.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20846       +/-   ##
===========================================
+ Coverage   45.36%   66.26%   +20.90%     
===========================================
  Files         244     1046      +802     
  Lines       13333   114162   +100829     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75655    +69606     
- Misses       6983    34384    +27401     
- Partials      301     4123     +3822     
Flag Coverage Δ
unittests 66.26% <25.00%> (+20.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/robot/controller.go 57.54% <100.00%> (ø)
src/controller/scan/base_controller.go 56.87% <100.00%> (ø)
src/pkg/robot/model/model.go 60.00% <ø> (ø)
src/server/v2.0/handler/model/robot.go 0.00% <0.00%> (ø)
src/server/v2.0/handler/robot.go 6.02% <0.00%> (ø)

... and 1281 files with indirect coverage changes

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

api/v2.0/swagger.yaml Outdated Show resolved Hide resolved
src/server/v2.0/handler/robot.go Outdated Show resolved Hide resolved
add the creator for robot creation

Signed-off-by: wang yan <[email protected]>
Signed-off-by: wang yan <[email protected]>
Signed-off-by: wang yan <[email protected]>
@wy65701436 wy65701436 merged commit 51eeb09 into goharbor:main Aug 15, 2024
11 of 12 checks passed
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
* add creator for robot

add the creator for robot creation

Signed-off-by: wang yan <[email protected]>

* resolve comments

Signed-off-by: wang yan <[email protected]>

* fix ut

Signed-off-by: wang yan <[email protected]>

---------

Signed-off-by: wang yan <[email protected]>
Signed-off-by: kunal-511 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants