Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the GC job index data race #20830

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 9, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.16%. Comparing base (c8c11b4) to head (5ae184f).
Report is 257 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20830      +/-   ##
==========================================
+ Coverage   45.36%   46.16%   +0.79%     
==========================================
  Files         244      247       +3     
  Lines       13333    13779     +446     
  Branches     2719     2845     +126     
==========================================
+ Hits         6049     6361     +312     
- Misses       6983     7088     +105     
- Partials      301      330      +29     
Flag Coverage Δ
unittests 46.16% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@chlins chlins force-pushed the fix/gc-index-data-race branch from c99324e to 5ae184f Compare August 12, 2024 11:48
@chlins chlins enabled auto-merge (squash) August 12, 2024 11:48
@chlins chlins merged commit ccceacf into goharbor:main Aug 12, 2024
12 checks passed
kunal-511 pushed a commit to kunal-511/harbor_local that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

5 participants