Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide the scan related button when installation without scanner #20616

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 18, 2024

Hide the scan related button when installation without scanner.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20615

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added the release-note/update Update or Fix label Jun 18, 2024
@chlins chlins requested a review from a team as a code owner June 18, 2024 04:33
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (b7b8847) to head (a7cf047).
Report is 224 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20616      +/-   ##
==========================================
- Coverage   67.56%   66.25%   -1.32%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113476    +4295     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75179    +1411     
- Misses      31449    34189    +2740     
- Partials     3964     4108     +144     
Flag Coverage Δ
unittests 66.25% <ø> (-1.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 572 files with indirect coverage changes

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MinerYang
Copy link
Contributor

MinerYang commented Jun 19, 2024

Hi @chlins ,
Could you help cherry-pick to release-2.11.0 ~ Big Thanks

@chlins
Copy link
Member Author

chlins commented Jun 20, 2024

Hi @chlins , Could you help cherry-pick to release-2.11.0 ~ Big Thanks

@MinerYang Sure, will do it.

@chlins chlins merged commit c75d08f into goharbor:main Jun 20, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scanning related inconsistent UI display issues
6 participants