Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close blob io ReadCloser #20225

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: close blob io ReadCloser #20225

merged 2 commits into from
Apr 9, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented Apr 4, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

close blob io ReadCloser

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@testwill testwill requested a review from a team as a code owner April 4, 2024 04:59
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.50%. Comparing base (b7b8847) to head (5913d44).
Report is 117 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20225      +/-   ##
==========================================
- Coverage   67.56%   67.50%   -0.07%     
==========================================
  Files         991      998       +7     
  Lines      109181   110098     +917     
  Branches     2719     2724       +5     
==========================================
+ Hits        73768    74319     +551     
- Misses      31449    31795     +346     
- Partials     3964     3984      +20     
Flag Coverage Δ
unittests 67.50% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/controller/artifact/annotation/v1alpha1.go 66.07% <100.00%> (+1.25%) ⬆️

... and 508 files with indirect coverage changes

@MinerYang
Copy link
Contributor

Hi @testwill ,

Appreciate your contribution!
May I know which lint/tools you are using to find this disclosure OR just get it manually?

Best,
Miner

@testwill
Copy link
Contributor Author

testwill commented Apr 8, 2024

just get it manually

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 added the release-note/update Update or Fix label Apr 9, 2024
@wy65701436 wy65701436 merged commit ff1a505 into goharbor:main Apr 9, 2024
12 of 13 checks passed
@testwill testwill deleted the controller branch April 9, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants