-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: close blob io ReadCloser #20225
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20225 +/- ##
==========================================
- Coverage 67.56% 67.50% -0.07%
==========================================
Files 991 998 +7
Lines 109181 110098 +917
Branches 2719 2724 +5
==========================================
+ Hits 73768 74319 +551
- Misses 31449 31795 +346
- Partials 3964 3984 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hi @testwill , Appreciate your contribution! Best, |
just get it manually |
Signed-off-by: guoguangwu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thank you for contributing to Harbor!
Comprehensive Summary of your change
close blob io ReadCloser
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: