Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh base images on release-2.9.0 #19246

Merged

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Aug 28, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #19246 (819f109) into release-2.9.0 (cdffb5e) will decrease coverage by 22.55%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.9.0   #19246       +/-   ##
==================================================
- Coverage          67.40%   44.85%   -22.55%     
==================================================
  Files                993      244      -749     
  Lines             108896    13412    -95484     
  Branches            2751     2751               
==================================================
- Hits               73400     6016    -67384     
+ Misses             31550     7090    -24460     
+ Partials            3946      306     -3640     
Flag Coverage Δ
unittests 44.85% <ø> (-22.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 753 files with indirect coverage changes

@YangJiao0817 YangJiao0817 enabled auto-merge (squash) August 28, 2023 03:26
@YangJiao0817 YangJiao0817 merged commit 44f5702 into goharbor:release-2.9.0 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes target/2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants