Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix: support customize cache db for business #19189

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 16, 2023

Support to configure the customized redis db for cache layer and other misc business for core, by default the behavior is same with previous(stored in db 0).

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19169

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Support to configure the customized redis db for cache layer and other
misc business for core, by default the behavior is same with
previous(stored in db 0).

Signed-off-by: chlins <[email protected]>
@chlins chlins requested a review from a team as a code owner August 16, 2023 03:40
@chlins chlins changed the title fix: support customize cache db for business [cherry-pick] fix: support customize cache db for business Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #19189 (fd12b0a) into release-2.7.0 (3db3d60) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.7.0   #19189      +/-   ##
=================================================
- Coverage          66.42%   66.38%   -0.04%     
=================================================
  Files               1012     1012              
  Lines             108674   108692      +18     
  Branches            2678     2678              
=================================================
- Hits               72183    72153      -30     
- Misses             32526    32574      +48     
  Partials            3965     3965              
Flag Coverage Δ
unittests 66.38% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/lib/cache/cache.go 64.40% <0.00%> (-28.28%) ⬇️
src/pkg/cached/base_manager.go 40.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit a324b2d into goharbor:release-2.7.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants