Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support customize cache db for business #19184

Merged

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 15, 2023

Support to configure the customized redis db for cache layer and other misc business for core, by default the behavior is same with previous(stored in db 0).

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #19169

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

src/lib/cache/cache.go Outdated Show resolved Hide resolved
make/harbor.yml.tmpl Outdated Show resolved Hide resolved
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Support to configure the customized redis db for cache layer and other
misc business for core, by default the behavior is same with
previous(stored in db 0).

Signed-off-by: chlins <[email protected]>
@chlins chlins force-pushed the release-2.8/fix/seperate-redis-db branch from 3461bc7 to 7a933e2 Compare August 15, 2023 08:13
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #19184 (7a933e2) into release-2.8.0 (3f10872) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19184      +/-   ##
=================================================
- Coverage          67.40%   67.33%   -0.07%     
=================================================
  Files                984      984              
  Lines             107051   107069      +18     
  Branches            2671     2671              
=================================================
- Hits               72154    72093      -61     
- Misses             31020    31095      +75     
- Partials            3877     3881       +4     
Flag Coverage Δ
unittests 67.33% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/lib/cache/cache.go 64.40% <0.00%> (-28.28%) ⬇️
src/pkg/cached/base_manager.go 40.00% <0.00%> (ø)

... and 14 files with indirect coverage changes

@zyyw zyyw merged commit ad3e767 into goharbor:release-2.8.0 Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants