Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix: fix replication list projects with pure numberic name #19092

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 3, 2023

Quote the project name when listing projects in the replication, resolve
the issue of pure number name of project.

Signed-off-by: chlins [email protected]

Comprehensive Summary of your change

Issue being fixed

Fixes #19027

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Quote the project name when listing projects in the replication, resolve
the issue of pure number name of project.

Signed-off-by: chlins <[email protected]>
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #19092 (4dfd987) into release-2.8.0 (8b2a7e9) will increase coverage by 0.02%.
Report is 1 commits behind head on release-2.8.0.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-2.8.0   #19092      +/-   ##
=================================================
+ Coverage          67.34%   67.36%   +0.02%     
=================================================
  Files                984      984              
  Lines             107025   107025              
  Branches            2670     2670              
=================================================
+ Hits               72073    72096      +23     
+ Misses             31073    31049      -24     
- Partials            3879     3880       +1     
Flag Coverage Δ
unittests 67.36% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pkg/reg/adapter/harbor/base/adapter.go 76.99% <100.00%> (ø)

... and 7 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit cd31bcb into goharbor:release-2.8.0 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants