Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show banner message on log in page #19078

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Aug 2, 2023

  1. Fixes Show banner_message on the login page #19076

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner August 2, 2023 05:51
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #19078 (32d2913) into main (1d81b3d) will decrease coverage by 22.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19078       +/-   ##
===========================================
- Coverage   67.42%   44.78%   -22.64%     
===========================================
  Files         992      244      -748     
  Lines      108751    13401    -95350     
  Branches     2749     2749               
===========================================
- Hits        73327     6002    -67325     
+ Misses      31491     7094    -24397     
+ Partials     3933      305     -3628     
Flag Coverage Δ
unittests 44.78% <0.00%> (-22.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...nts/app-level-alerts/app-level-alerts.component.ts 41.57% <0.00%> (ø)
src/portal/src/app/shared/shared.module.ts 100.00% <ø> (ø)

... and 753 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 26b53ef into goharbor:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show banner_message on the login page
6 participants