Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vulnerability search API #18924

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jul 12, 2023

use q.Query to pass all query conditions

Signed-off-by: stonezdj [email protected]

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner July 12, 2023 12:16
@stonezdj stonezdj changed the title Add vulnerability search API [WIP] Add vulnerability search API Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #18924 (71a1c6d) into main (82ee529) will increase coverage by 0.01%.
The diff coverage is 44.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18924      +/-   ##
==========================================
+ Coverage   67.43%   67.44%   +0.01%     
==========================================
  Files         986      986              
  Lines      107995   108530     +535     
  Branches     2698     2698              
==========================================
+ Hits        72831    73203     +372     
- Misses      31263    31408     +145     
- Partials     3901     3919      +18     
Flag Coverage Δ
unittests 67.44% <44.69%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/securityhub/manager.go 25.00% <0.00%> (-8.34%) ⬇️
src/server/v2.0/handler/security.go 0.00% <0.00%> (ø)
src/pkg/securityhub/dao/security.go 50.80% <49.62%> (-3.05%) ⬇️
src/pkg/scan/scanner/manager.go 40.74% <50.00%> (+1.15%) ⬆️
src/controller/securityhub/controller.go 76.04% <83.78%> (+0.28%) ⬆️

... and 12 files with indirect coverage changes

@stonezdj stonezdj assigned wy65701436 and unassigned MinerYang and Vad1mo Jul 12, 2023
@stonezdj stonezdj force-pushed the 23jun12_main_security_hub branch from 2b18976 to bdd5c44 Compare July 12, 2023 12:26
@stonezdj stonezdj added the release-note/new-feature New Harbor Feature label Jul 12, 2023
@stonezdj stonezdj changed the title [WIP] Add vulnerability search API Add vulnerability search API Jul 12, 2023
@stonezdj stonezdj force-pushed the 23jun12_main_security_hub branch 4 times, most recently from 6c19ef1 to 297b5ed Compare July 17, 2023 06:18
@stonezdj stonezdj force-pushed the 23jun12_main_security_hub branch from 297b5ed to 85bb524 Compare July 17, 2023 07:21
@stonezdj stonezdj force-pushed the 23jun12_main_security_hub branch 4 times, most recently from 92791aa to 1551799 Compare July 17, 2023 10:56
@AllForNothing AllForNothing mentioned this pull request Jul 17, 2023
5 tasks
@stonezdj stonezdj force-pushed the 23jun12_main_security_hub branch 3 times, most recently from a130dae to f6ebe95 Compare July 18, 2023 07:24
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 23jun12_main_security_hub branch 3 times, most recently from 8dc34c1 to 1b85478 Compare July 18, 2023 10:02
  use q.Query to pass all query conditions

Signed-off-by: stonezdj <[email protected]>
@stonezdj stonezdj force-pushed the 23jun12_main_security_hub branch from 1b85478 to 71a1c6d Compare July 18, 2023 10:24
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit d4aa9b1 into goharbor:main Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature New Harbor Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants