-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replication policy cron setting - the 1st field must be 0; the Minutes field cannot be * #18923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18923 +/- ##
==========================================
- Coverage 67.44% 67.40% -0.04%
==========================================
Files 993 993
Lines 108768 108775 +7
Branches 2747 2747
==========================================
- Hits 73356 73324 -32
- Misses 31480 31518 +38
- Partials 3932 3933 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zyyw
force-pushed
the
replication-cron-check
branch
from
July 13, 2023 07:36
05b20a8
to
e1c2ea3
Compare
…inutes field cannot be * Signed-off-by: Shengwen Yu <[email protected]>
zyyw
force-pushed
the
replication-cron-check
branch
from
July 13, 2023 07:37
e1c2ea3
to
4d08048
Compare
zyyw
changed the title
fix: * is not allowed in Seconds field of replication cron setting
fix: replication policy cron setting - the 1st field must be 0; the Minutes field cannot be *
Jul 13, 2023
stonezdj
approved these changes
Jul 14, 2023
AllForNothing
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
YangJiao0817
pushed a commit
to YangJiao0817/harbor
that referenced
this pull request
Jul 21, 2023
Sync test case updates because of changes to webhook and replication 1. goharbor#18923 2. goharbor#18906 Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817
pushed a commit
to YangJiao0817/harbor
that referenced
this pull request
Jul 24, 2023
Sync test case updates because of changes to webhook and replication 1. goharbor#18923 2. goharbor#18906 Signed-off-by: Yang Jiao <[email protected]>
MinerYang
pushed a commit
that referenced
this pull request
Jul 24, 2023
…inutes field cannot be * (#18923) Signed-off-by: Shengwen Yu <[email protected]>
YangJiao0817
pushed a commit
to YangJiao0817/harbor
that referenced
this pull request
Jul 25, 2023
Sync test case updates because of changes to webhook and replication 1. goharbor#18923 2. goharbor#18906 Signed-off-by: Yang Jiao <[email protected]>
5 tasks
YangJiao0817
pushed a commit
to YangJiao0817/harbor
that referenced
this pull request
Jul 25, 2023
Sync test case updates because of changes to webhook and replication 1. goharbor#18923 2. goharbor#18906 Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817
added a commit
that referenced
this pull request
Jul 25, 2023
Sync test case updates because of changes to webhook and replication 1. #18923 2. #18906 Signed-off-by: Yang Jiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Resolve task 3 in issue 18091
Please indicate you've done the following: