Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replication policy cron setting - the 1st field must be 0; the Minutes field cannot be * #18923

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jul 12, 2023

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)
Resolve task 3 in issue 18091

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #18923 (f13ae00) into main (ce89363) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18923      +/-   ##
==========================================
- Coverage   67.44%   67.40%   -0.04%     
==========================================
  Files         993      993              
  Lines      108768   108775       +7     
  Branches     2747     2747              
==========================================
- Hits        73356    73324      -32     
- Misses      31480    31518      +38     
- Partials     3932     3933       +1     
Flag Coverage Δ
unittests 67.40% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/replication/model/model.go 47.80% <100.00%> (+1.65%) ⬆️

... and 8 files with indirect coverage changes

@zyyw zyyw force-pushed the replication-cron-check branch from 05b20a8 to e1c2ea3 Compare July 13, 2023 07:36
…inutes field cannot be *

Signed-off-by: Shengwen Yu <[email protected]>
@zyyw zyyw force-pushed the replication-cron-check branch from e1c2ea3 to 4d08048 Compare July 13, 2023 07:37
@zyyw zyyw changed the title fix: * is not allowed in Seconds field of replication cron setting fix: replication policy cron setting - the 1st field must be 0; the Minutes field cannot be * Jul 13, 2023
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 9091661 into goharbor:main Jul 20, 2023
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jul 21, 2023
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jul 24, 2023
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <[email protected]>
MinerYang pushed a commit that referenced this pull request Jul 24, 2023
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jul 25, 2023
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jul 25, 2023
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817 added a commit that referenced this pull request Jul 25, 2023
Sync test case updates because of changes to webhook and replication
1. #18923
2. #18906

Signed-off-by: Yang Jiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants