Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick]Add OIDC filter group testcase #18915

Merged
merged 1 commit into from
Jul 11, 2023
Merged

[cherry-pick]Add OIDC filter group testcase #18915

merged 1 commit into from
Jul 11, 2023

Conversation

YangJiao0817
Copy link
Member

@YangJiao0817 YangJiao0817 commented Jul 11, 2023 •
edited
Loading

Fix #17950

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Jul 11, 2023
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner July 11, 2023 06:29
@YangJiao0817 YangJiao0817 changed the title Add OIDC filter group testcase [cherry-pick]Add OIDC filter group testcase Jul 11, 2023
chlins
chlins approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 merged commit 46cd4f5 into goharbor:release-2.8.0 Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@AllForNothing AllForNothing AllForNothing approved these changes

Assignees

@Vad1mo Vad1mo

@wy65701436 wy65701436

@AllForNothing AllForNothing

@chlins chlins

@MinerYang MinerYang

@YangJiao0817 YangJiao0817

Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YangJiao0817 @AllForNothing @chlins @Vad1mo @wy65701436 @MinerYang