Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the operator in the webhook payload #18906

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Jul 9, 2023

Fix the incorrect or meaningless operator in the webhook payload.

Fixes: #18438

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #18438

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins requested a review from a team as a code owner July 9, 2023 08:40
@chlins chlins force-pushed the fix/webhook-operator branch 4 times, most recently from 47608c8 to 90f3e70 Compare July 11, 2023 07:08
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the fix/webhook-operator branch from 90f3e70 to 023b3a9 Compare July 18, 2023 06:54
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #18906 (5d762d1) into main (d4aa9b1) will decrease coverage by 0.05%.
The diff coverage is 49.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18906      +/-   ##
==========================================
- Coverage   67.47%   67.43%   -0.05%     
==========================================
  Files         986      986              
  Lines      108530   108614      +84     
  Branches     2698     2698              
==========================================
+ Hits        73231    73241      +10     
- Misses      31380    31438      +58     
- Partials     3919     3935      +16     
Flag Coverage Δ
unittests 67.43% <49.07%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/event/handler/internal/artifact.go 75.00% <0.00%> (-1.34%) ⬇️
...roller/event/handler/webhook/artifact/retention.go 15.51% <0.00%> (ø)
src/controller/event/topic.go 6.47% <ø> (ø)
src/controller/retention/callback.go 13.33% <0.00%> (-3.34%) ⬇️
src/controller/scan/callback.go 64.61% <12.50%> (-17.74%) ⬇️
src/controller/scan/base_controller.go 59.55% <33.33%> (-0.67%) ⬇️
src/controller/replication/execution.go 67.59% <45.45%> (-1.82%) ⬇️
src/controller/replication/policy.go 38.57% <47.61%> (+2.79%) ⬆️
src/controller/retention/controller.go 47.52% <66.66%> (-0.12%) ⬇️
...ller/event/handler/webhook/artifact/replication.go 47.20% <100.00%> (ø)
... and 6 more

... and 8 files with indirect coverage changes

@chlins chlins force-pushed the fix/webhook-operator branch from 023b3a9 to 1947e28 Compare July 18, 2023 07:01
@chlins chlins force-pushed the fix/webhook-operator branch from 1947e28 to 424cea0 Compare July 19, 2023 05:43
Fix the incorrect or meaningless operator in the webhook payload.

Fixes: goharbor#18438

Signed-off-by: chlins <[email protected]>
@chlins chlins force-pushed the fix/webhook-operator branch from 424cea0 to 5d762d1 Compare July 19, 2023 06:36
@chlins chlins merged commit 970bdab into goharbor:main Jul 19, 2023
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jul 21, 2023
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jul 24, 2023
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jul 25, 2023
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817 pushed a commit to YangJiao0817/harbor that referenced this pull request Jul 25, 2023
Sync test case updates because of changes to webhook and replication
1. goharbor#18923
2. goharbor#18906

Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817 added a commit that referenced this pull request Jul 25, 2023
Sync test case updates because of changes to webhook and replication
1. #18923
2. #18906

Signed-off-by: Yang Jiao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The operator field in the webhook payload is incorrect
5 participants