-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct the operator in the webhook payload #18906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlins
force-pushed
the
fix/webhook-operator
branch
4 times, most recently
from
July 11, 2023 07:08
47608c8
to
90f3e70
Compare
stonezdj
reviewed
Jul 14, 2023
wy65701436
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
chlins
force-pushed
the
fix/webhook-operator
branch
from
July 18, 2023 06:54
90f3e70
to
023b3a9
Compare
Codecov Report
@@ Coverage Diff @@
## main #18906 +/- ##
==========================================
- Coverage 67.47% 67.43% -0.05%
==========================================
Files 986 986
Lines 108530 108614 +84
Branches 2698 2698
==========================================
+ Hits 73231 73241 +10
- Misses 31380 31438 +58
- Partials 3919 3935 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
force-pushed
the
fix/webhook-operator
branch
from
July 18, 2023 07:01
023b3a9
to
1947e28
Compare
stonezdj
approved these changes
Jul 19, 2023
chlins
force-pushed
the
fix/webhook-operator
branch
from
July 19, 2023 05:43
1947e28
to
424cea0
Compare
Fix the incorrect or meaningless operator in the webhook payload. Fixes: goharbor#18438 Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
fix/webhook-operator
branch
from
July 19, 2023 06:36
424cea0
to
5d762d1
Compare
YangJiao0817
pushed a commit
to YangJiao0817/harbor
that referenced
this pull request
Jul 21, 2023
Sync test case updates because of changes to webhook and replication 1. goharbor#18923 2. goharbor#18906 Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817
pushed a commit
to YangJiao0817/harbor
that referenced
this pull request
Jul 24, 2023
Sync test case updates because of changes to webhook and replication 1. goharbor#18923 2. goharbor#18906 Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817
pushed a commit
to YangJiao0817/harbor
that referenced
this pull request
Jul 25, 2023
Sync test case updates because of changes to webhook and replication 1. goharbor#18923 2. goharbor#18906 Signed-off-by: Yang Jiao <[email protected]>
5 tasks
YangJiao0817
pushed a commit
to YangJiao0817/harbor
that referenced
this pull request
Jul 25, 2023
Sync test case updates because of changes to webhook and replication 1. goharbor#18923 2. goharbor#18906 Signed-off-by: Yang Jiao <[email protected]>
YangJiao0817
added a commit
that referenced
this pull request
Jul 25, 2023
Sync test case updates because of changes to webhook and replication 1. #18923 2. #18906 Signed-off-by: Yang Jiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the incorrect or meaningless operator in the webhook payload.
Fixes: #18438
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #18438
Please indicate you've done the following: