Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the hidden property for clrDgHideableColumn #18890

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jul 5, 2023

1.Fixes #18870

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #18890 (6f41eeb) into main (1d2624e) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18890      +/-   ##
==========================================
+ Coverage   67.37%   67.39%   +0.01%     
==========================================
  Files         981      981              
  Lines      107193   107194       +1     
  Branches     2698     2698              
==========================================
+ Hits        72224    72244      +20     
+ Misses      31088    31069      -19     
  Partials     3881     3881              
Flag Coverage Δ
unittests 67.39% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@AllForNothing AllForNothing removed the request for review from chlins July 5, 2023 05:56
@YangJiao0817 YangJiao0817 removed the request for review from a team July 5, 2023 05:59
@stonezdj stonezdj merged commit 1efe944 into goharbor:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List artifact page columns are displayed incorrectly by default
6 participants