Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add worker parameter for GC #18882

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jul 3, 2023

  1. Related back-end PR add multiple deletion of GC #18855
    image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner July 3, 2023 05:26
@AllForNothing AllForNothing added the release-note/new-feature New Harbor Feature label Jul 3, 2023
@AllForNothing AllForNothing added the doc-impact Engineering issues that will require a change in user docs label Jul 3, 2023
@AllForNothing
Copy link
Contributor Author

@OrlinVasilev Kindly help review the English text for the tooltip, thanks!

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #18882 (f5a24d5) into main (ef96c72) will increase coverage by 22.72%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18882       +/-   ##
===========================================
+ Coverage   44.65%   67.38%   +22.72%     
===========================================
  Files         236      981      +745     
  Lines       13173   107193    +94020     
  Branches     2698     2698               
===========================================
+ Hits         5883    72233    +66350     
- Misses       6995    31080    +24085     
- Partials      295     3880     +3585     
Flag Coverage Δ
unittests 67.38% <80.00%> (+22.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-side-nav/clearing-job/gc-page/gc/gc.component.ts 62.02% <75.00%> (+0.69%) ⬆️
...ft-side-nav/clearing-job/clearing-job-interfact.ts 100.00% <100.00%> (ø)

... and 748 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

1. Related back-end PR goharbor#18855

Signed-off-by: AllForNothing <[email protected]>
@AllForNothing AllForNothing merged commit 1d2624e into goharbor:main Jul 4, 2023
@Vad1mo Vad1mo added the area/gc label Jul 14, 2023
@Vad1mo
Copy link
Member

Vad1mo commented Jul 14, 2023

what is the target for this feature 2.9? or 2.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gc doc-impact Engineering issues that will require a change in user docs release-note/new-feature New Harbor Feature
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

7 participants