Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade golang-migrate to v4.16.2 #18879

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Jul 2, 2023

Upgrade golang-migrate to v4.16.2.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #18698

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #18879 (63d1a37) into main (78799cc) will decrease coverage by 22.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18879       +/-   ##
===========================================
- Coverage   67.35%   44.74%   -22.61%     
===========================================
  Files         981      236      -745     
  Lines      107342    13178    -94164     
  Branches     2698     2698               
===========================================
- Hits        72295     5896    -66399     
+ Misses      31163     6987    -24176     
+ Partials     3884      295     -3589     
Flag Coverage Δ
unittests 44.74% <ø> (-22.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 747 files with indirect coverage changes

@chlins chlins assigned wy65701436 and unassigned OrlinVasilev Jul 3, 2023
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the chore/bump-golang-migrate-v4.16.2 branch from 977a341 to 63d1a37 Compare July 11, 2023 01:25
@chlins chlins merged commit 98f592f into goharbor:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade migrate binary to v4.15.2
5 participants