Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobservice: update readme #18849

Merged
merged 1 commit into from
Jun 27, 2023
Merged

jobservice: update readme #18849

merged 1 commit into from
Jun 27, 2023

Conversation

liubin
Copy link
Contributor

@liubin liubin commented Jun 25, 2023

Thank you for contributing to Harbor!

To reflect the newest job interface, and the missing parts of DB job service logger.

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

To reflect the newest job interface, and the missing parts of
DB job service logger.

Signed-off-by: bin liu <[email protected]>
@liubin liubin requested a review from a team as a code owner June 25, 2023 07:18
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #18849 (ea8d6e0) into main (b822952) will increase coverage by 22.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #18849       +/-   ##
===========================================
+ Coverage   44.71%   67.36%   +22.65%     
===========================================
  Files         235      980      +745     
  Lines       13083   106883    +93800     
  Branches     2671     2671               
===========================================
+ Hits         5850    72004    +66154     
- Misses       6938    31007    +24069     
- Partials      295     3872     +3577     
Flag Coverage Δ
unittests 67.36% <ø> (+22.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/jobservice/mgt/manager.go 59.55% <ø> (ø)

... and 746 files with indirect coverage changes

Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrlinVasilev OrlinVasilev requested a review from wy65701436 June 26, 2023 07:39
@stonezdj stonezdj self-requested a review June 26, 2023 08:53
@stonezdj stonezdj added the release-note/update Update or Fix label Jun 26, 2023
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 1d6c02f into goharbor:main Jun 27, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
To reflect the newest job interface, and the missing parts of
DB job service logger.

Signed-off-by: bin liu <[email protected]>
Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
To reflect the newest job interface, and the missing parts of
DB job service logger.

Signed-off-by: bin liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants