Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Details column for gc history #18797

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jun 8, 2023

  1. Related add more details in gc history #18779
  2. Show how many blobs and manifest have been deleted and how much space has been freed up
image

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner June 8, 2023 07:46
@AllForNothing AllForNothing added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Jun 8, 2023
1. Related goharbor#18779
2. Show how many blobs and manifest have been deleted and how much space has been freed up

Signed-off-by: AllForNothing <[email protected]>
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #18797 (88d78eb) into main (c08c7c5) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 88d78eb differs from pull request most recent head 690d177. Consider uploading reports for the commit 690d177 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18797      +/-   ##
==========================================
- Coverage   67.40%   67.37%   -0.03%     
==========================================
  Files         980      980              
  Lines      106867   106882      +15     
  Branches     2665     2671       +6     
==========================================
- Hits        72033    72016      -17     
- Misses      30959    30993      +34     
+ Partials     3875     3873       -2     
Flag Coverage Δ
unittests 67.37% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-job/gc-page/gc/gc-history/gc-history.component.ts 39.60% <0.00%> (-6.91%) ⬇️

... and 7 files with indirect coverage changes

@Vad1mo Vad1mo added the area/i18n Related to Translation changes. label Jun 8, 2023
Copy link
Member

@OrlinVasilev OrlinVasilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit fc9c68a into goharbor:main Jun 12, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1. Related goharbor#18779
2. Show how many blobs and manifest have been deleted and how much space has been freed up

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1. Related goharbor#18779
2. Show how many blobs and manifest have been deleted and how much space has been freed up

Signed-off-by: AllForNothing <[email protected]>
@Vad1mo Vad1mo added the area/gc label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gc area/i18n Related to Translation changes. release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

6 participants