Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize the mechanism of quota refresh #18795

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 8, 2023

Optimize the mechanism of quota refresh, return earlier to reduce the conflicts of optimistic lock. This is a follow-up fix to the #17392.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@chlins chlins added the release-note/update Update or Fix label Jun 8, 2023
@chlins chlins requested a review from a team as a code owner June 8, 2023 03:41
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #18795 (8947edf) into main (8251fd2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18795      +/-   ##
==========================================
- Coverage   67.39%   67.37%   -0.02%     
==========================================
  Files         980      980              
  Lines      106864   106867       +3     
  Branches     2665     2665              
==========================================
- Hits        72020    72001      -19     
- Misses      30971    30994      +23     
+ Partials     3873     3872       -1     
Flag Coverage Δ
unittests 67.37% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/quota/controller.go 45.65% <100.00%> (+0.90%) ⬆️

... and 11 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit c08c7c5 into goharbor:main Jun 8, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants