Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more details in gc history #18779

Merged
merged 2 commits into from
Jun 2, 2023
Merged

Conversation

wy65701436
Copy link
Contributor

@wy65701436 wy65701436 commented Jun 1, 2023

Show more infors in the gc history, like the sweep size and how many blobs and manifests were removed by GC.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #18779 (45367eb) into main (97c1fdc) will decrease coverage by 0.06%.
The diff coverage is 36.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18779      +/-   ##
==========================================
- Coverage   67.39%   67.33%   -0.06%     
==========================================
  Files         980      980              
  Lines      106774   106831      +57     
  Branches     2665     2665              
==========================================
- Hits        71962    71938      -24     
- Misses      30948    31024      +76     
- Partials     3864     3869       +5     
Flag Coverage Δ
unittests 67.33% <36.66%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/controller/gc/callback.go 13.33% <15.78%> (+4.63%) ⬆️
src/jobservice/job/impl/gc/garbage_collection.go 46.80% <72.72%> (+1.03%) ⬆️

... and 10 files with indirect coverage changes

@wy65701436 wy65701436 force-pushed the gc-more-details branch 2 times, most recently from 85c5075 to 9f2bccf Compare June 2, 2023 03:10
@wy65701436 wy65701436 added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Jun 2, 2023
Show more infors in the gc history, like the sweep size and how many blobs and manifests were removed by GC.

Signed-off-by: Wang Yan <[email protected]>
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit 680c78d into goharbor:main Jun 2, 2023
AllForNothing pushed a commit to AllForNothing/harbor that referenced this pull request Jun 8, 2023
1. Related goharbor#18779
2. Show how many blobs and manifest have been deleted and how much space has been freed up

Signed-off-by: AllForNothing <[email protected]>
AllForNothing pushed a commit to AllForNothing/harbor that referenced this pull request Jun 8, 2023
1. Related goharbor#18779
2. Show how many blobs and manifest have been deleted and how much space has been freed up

Signed-off-by: AllForNothing <[email protected]>
AllForNothing added a commit that referenced this pull request Jun 12, 2023
1. Related #18779
2. Show how many blobs and manifest have been deleted and how much space has been freed up

Signed-off-by: AllForNothing <[email protected]>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Show more infors in the gc history, like the sweep size and how many blobs and manifests were removed by GC.

Signed-off-by: Wang Yan <[email protected]>
Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1. Related goharbor#18779
2. Show how many blobs and manifest have been deleted and how much space has been freed up

Signed-off-by: AllForNothing <[email protected]>
Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Show more infors in the gc history, like the sweep size and how many blobs and manifests were removed by GC.

Signed-off-by: Wang Yan <[email protected]>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
1. Related goharbor#18779
2. Show how many blobs and manifest have been deleted and how much space has been freed up

Signed-off-by: AllForNothing <[email protected]>
@Vad1mo Vad1mo added the area/gc label Jul 14, 2023
@Vad1mo
Copy link
Member

Vad1mo commented Jul 14, 2023

when is it planned for 2.9 or 2.10?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gc release-note/enhancement Label to mark PR to be added under release notes as enhancement
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

6 participants