【UT】add unit test for collector system info #18717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18717 +/- ##
===========================================
+ Coverage 44.77% 67.43% +22.65%
===========================================
Files 235 980 +745
Lines 13067 106774 +93707
Branches 2665 2665
===========================================
+ Hits 5851 72005 +66154
- Misses 6921 30899 +23978
- Partials 295 3870 +3575
Flags with carried forward coverage won't be shown. Click here to find out more. |
lengrongfu
force-pushed
the
test/add_test_systeminfocontroller
branch
3 times, most recently
from
6a253c8 to
3125665
Compare
|
@Vad1mo @OrlinVasilev Hi, PTAL. |
AllForNothing
added
the
release-note/enhancement
AllForNothing
assigned stonezdj and chlins and unassigned Vad1mo, zyyw and OrlinVasilev
AllForNothing
force-pushed
the
test/add_test_systeminfocontroller
branch
from
3125665 to
3e5a156
Compare
|
thanks @lengrongfu for your contribution, please add description of the PR according to this. |
chlins
requested changes
Jun 2, 2023
lengrongfu
changed the title
|
@wy65701436 @chlins add this pr description, PTAL. |
Signed-off-by: lengrongfu <[email protected]>
chlins
force-pushed
the
test/add_test_systeminfocontroller
branch
from
32060c6 to
2e045e8
Compare
stonezdj
approved these changes
Jun 8, 2023
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
add unit test for system collector test Signed-off-by: lengrongfu <[email protected]> Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
add unit test for system collector test Signed-off-by: lengrongfu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
add unit test for collector system info.
Issue being fixed
Fixes #(issue)
/label release-note/enhancement
Please indicate you've done the following: