fix: sweep executions of image scan job #18649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #18649 +/- ##
==========================================
- Coverage 67.40% 67.37% -0.04%
==========================================
Files 984 984
Lines 107029 107029
Branches 2670 2670
==========================================
- Hits 72139 72106 -33
- Misses 31005 31040 +35
+ Partials 3885 3883 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
force-pushed
the
fix/sweep-image-scan-exec
branch
from
87d85ba to
0460159
Compare
zyyw
approved these changes
May 9, 2023
zyyw
reviewed
May 9, 2023
| @@ -1 +1,7 @@ | |||
| CREATE INDEX IF NOT EXISTS idx_task_extra_attrs_report_uuids ON task USING gin ((extra_attrs::jsonb->'report_uuids')); | |||
|
|
|||
| /* Set the vendor_id of IMAGE_SCAN to the artifact id instead of scanner id, which facilitates execution sweep */ | |||
There was a problem hiding this comment.
Could you please elaborate why changing the vendor_id of IMAGE_SCAN from scanner-id to artifact-id will facilitate the execution sweep? Thanks
There was a problem hiding this comment.
Currently, the unified sweep logic is cleaning the executions by vendor_id, an easy-to-understand example is replication, we set the vendor_id to replication policy id then we can retain fixed executions per policy, likewise for scanning, we want retain one execution for every artifact so need the vendor_id to be the artifact id.
1. Change the SCAN_ALL job execution retain counts from 5 to 1(per current design, only one report be stored for every artifact, so retain latest 1 is enough). 2. Enable the sweep for IMAGE_SCAN job(retain latest 1). Fixes: goharbor#18633 Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
fix/sweep-image-scan-exec
branch
from
0460159 to
2bd45f7
Compare
WilfredAlmeida
pushed a commit
to WilfredAlmeida/harbor
that referenced
this pull request
Jul 8, 2023
1. Change the SCAN_ALL job execution retain counts from 5 to 1(per current design, only one report be stored for every artifact, so retain latest 1 is enough). 2. Enable the sweep for IMAGE_SCAN job(retain latest 1). Fixes: goharbor#18633 Signed-off-by: chlins <[email protected]> Signed-off-by: Wilfred Almeida <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18633
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #18633
Please indicate you've done the following: