Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link to Github's rate limiting documentation. #18588

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

perjahn
Copy link
Contributor

@perjahn perjahn commented Apr 24, 2023

The link Github's rate limiting documentation in the template for harbor.yml file appear to be old and is redirected to root page of Github's rest api documentation.

Issue being fixed

The new link in this PR has been updated to point to the correct documentation.

@stonezdj stonezdj self-requested a review April 24, 2023 08:54
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #18588 (1667dcf) into main (ebac530) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18588      +/-   ##
==========================================
+ Coverage   67.37%   67.38%   +0.01%     
==========================================
  Files         984      984              
  Lines      107010   107010              
  Branches     2670     2670              
==========================================
+ Hits        72099    72113      +14     
+ Misses      31035    31018      -17     
- Partials     3876     3879       +3     
Flag Coverage Δ
unittests 67.38% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@OrlinVasilev OrlinVasilev merged commit e20e440 into goharbor:main Apr 25, 2023
@OrlinVasilev
Copy link
Member

@perjahn congrats on merging your first PR here :)) welcome to the club :) if there is anything else I can help you with just DM:)

WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants