Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed logic search projects in gitlab adapter #18529

Merged
merged 4 commits into from
May 15, 2023

Conversation

lxShaDoWxl
Copy link
Contributor

Comprehensive Summary of your change

Changed logic search projects in gitlab adapter for correction search projects

Issue being fixed

Fixes #18284

@lxShaDoWxl lxShaDoWxl requested a review from a team as a code owner April 13, 2023 12:37
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #18529 (391448a) into main (362387f) will increase coverage by 0.00%.
The diff coverage is 94.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #18529   +/-   ##
=======================================
  Coverage   67.37%   67.38%           
=======================================
  Files         984      984           
  Lines      107029   107027    -2     
  Branches     2670     2670           
=======================================
+ Hits        72116    72117    +1     
+ Misses      31031    31030    -1     
+ Partials     3882     3880    -2     
Flag Coverage Δ
unittests 67.38% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pkg/reg/adapter/gitlab/adapter.go 58.59% <92.85%> (+0.57%) ⬆️
src/pkg/reg/adapter/gitlab/client.go 48.62% <100.00%> (+1.45%) ⬆️

... and 7 files with indirect coverage changes

@chlins chlins self-assigned this Apr 14, 2023
@chlins chlins added release-note/update Update or Fix replication/adapters related to replication adapters labels Apr 17, 2023
@chlins
Copy link
Member

chlins commented Apr 19, 2023

@lxShaDoWxl Thanks for your help, the changes look good to me, but let's hold for the verification from user.

@chlins
Copy link
Member

chlins commented Apr 26, 2023

@lxShaDoWxl The CI UTTEST failed, please fix it.

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wy65701436 wy65701436 merged commit f8e28db into goharbor:main May 15, 2023
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
* fix(gitlab): change logic search projects usage search_namespaces

Signed-off-by: lxShaDoWxl <[email protected]>

* tests(gitlab): remove old data and actualization test

Signed-off-by: lxShaDoWxl <[email protected]>

* refactor(gitlab): added debug log

Signed-off-by: lxShaDoWxl <[email protected]>
(cherry picked from commit 7328062)

* lint(gitlab): fix import order

Signed-off-by: lxShaDoWxl <[email protected]>

---------

Signed-off-by: lxShaDoWxl <[email protected]>
Signed-off-by: Wilfred Almeida <[email protected]>
WilfredAlmeida pushed a commit to WilfredAlmeida/harbor that referenced this pull request Jul 8, 2023
* fix(gitlab): change logic search projects usage search_namespaces

Signed-off-by: lxShaDoWxl <[email protected]>

* tests(gitlab): remove old data and actualization test

Signed-off-by: lxShaDoWxl <[email protected]>

* refactor(gitlab): added debug log

Signed-off-by: lxShaDoWxl <[email protected]>
(cherry picked from commit 7328062)

* lint(gitlab): fix import order

Signed-off-by: lxShaDoWxl <[email protected]>

---------

Signed-off-by: lxShaDoWxl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix replication/adapters related to replication adapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replication Issue with GitLab
6 participants