feat: log with trace ID #18181
Merged
feat: log with trace ID #18181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgillich
force-pushed
the
log_with_trace_id
branch
3 times, most recently
from
29fac0f to
6666eff
Compare
Codecov Report
@@ Coverage Diff @@
## main #18181 +/- ##
==========================================
+ Coverage 67.39% 67.40% +0.01%
==========================================
Files 984 984
Lines 106990 107010 +20
Branches 2670 2670
==========================================
+ Hits 72110 72135 +25
+ Misses 30999 30995 -4
+ Partials 3881 3880 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Vad1mo
approved these changes
Apr 12, 2023
Implements goharbor#18029 If the Trace ID is sent to the Harbor in HTTP header or the tracing is enabled (and the Trace ID is generated), the Trace ID will be added to the log lines as a new field. Signed-off-by: Peter Gillich <[email protected]>
chlins
force-pushed
the
log_with_trace_id
branch
from
d388dbc to
5077228
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Trace ID is sent to the Harbor in HTTP header or the tracing is enabled (and the Trace ID is generated), the Trace ID will be added to the log lines as a new field.
Signed-off-by: Peter Gillich [email protected]
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Implements #18029
Please indicate you've done the following: